Page MenuHomePhabricator

[WebAssembly] Support EXPLICIT_NAME symbols in llvm-readobj
ClosedPublic

Authored by sunfish on Apr 30 2019, 10:01 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sunfish created this revision.Apr 30 2019, 10:01 AM

I've tried to avoid checking in binaries when possible. Can you not check-in a yaml file instead and build the binary with yaml2obj?

sunfish updated this revision to Diff 197395.Apr 30 2019, 11:50 AM
  • Convert the test input to yaml.
  • Add ObjectYAML support for EXPLICIT_NAME symbols too.
sbc100 accepted this revision.Apr 30 2019, 12:05 PM

I was thinking of embedding a minimal yaml in the test itself (and calling it test/tools/llvm-readobj/wasm-imports.yaml).. e.g. llvm/test/Object/wasm-duplicate-name.test or llvm/test/tools/llvm-readobj/wasm-invalid.test.

I don't feel strongly about it though. lgtm either way.

This revision is now accepted and ready to land.Apr 30 2019, 12:05 PM
This revision was automatically updated to reflect the committed changes.
jfb added a subscriber: jfb.EditedApr 30 2019, 1:05 PM

Looks like this broke some tests:

/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm/test/MC/WebAssembly/import-module.ll:28:15: error: CHECK-NEXT: is not on the line after the previous match
; CHECK-NEXT: Flags: [ UNDEFINED ]
              ^
<stdin>:63:2: note: 'next' match was here
 Flags: [ UNDEFINED ]
 ^
<stdin>:57:11: note: previous match ended here
 Name: foo
          ^
<stdin>:58:1: note: non-matching line after previous match is here
 Flags: [ UNDEFINED, EXPLICIT_NAME ]
^

http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/60583/consoleFull

Fixed in r359605.