This is an archive of the discontinued LLVM Phabricator instance.

Differential D61279

[PDB] Fixed null pointer dereference
ClosedPublic

Authored by xbolva00 on Apr 29 2019, 2:10 PM.

Details

Reviewers
zturner
rnk
Commits
rG1a52eaf77338: [PDB] Fixed null pointer dereference
rL359520: [PDB] Fixed null pointer dereference

Diff Detail

Repository
rL LLVM

Event Timeline

xbolva00 created this revision.Apr 29 2019, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 2:10 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
xbolva00 added a reviewer: rnk.Apr 29 2019, 4:22 PM
rnk accepted this revision.Apr 29 2019, 4:38 PM

lgtm, nice

This revision is now accepted and ready to land.Apr 29 2019, 4:38 PM
Closed by commit rL359520: [PDB] Fixed null pointer dereference (authored by xbolva00). · Explain WhyApr 29 2019, 4:57 PM
This revision was automatically updated to reflect the committed changes.
RKSimon added a subscriber: RKSimon.Apr 30 2019, 2:34 AM
RKSimon added inline comments.
llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
231 ↗(On Diff #197224)

@xbolva00 Doesn't this undo the fix I put in at rL359488? We don't want to call dump if Type is null

xbolva00 marked an inline comment as done.Apr 30 2019, 4:21 AM
xbolva00 added inline comments.
llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
231 ↗(On Diff #197224)

Reverted.

Revision Contents

PathSize
tools/
llvm-pdbutil/
2 lines

Diff 197183

tools/llvm-pdbutil/PrettyFunctionDumper.cpp

Show First 20 Lines • Show All 221 Lines • ▼ Show 20 Linesvoid FunctionDumper::dump(const PDBSymbolTypeEnum &Symbol) {
WithColor(Printer, PDB_ColorItem::Type).get() << Symbol.getName(); WithColor(Printer, PDB_ColorItem::Type).get() << Symbol.getName();
} }
void FunctionDumper::dump(const PDBSymbolTypeFunctionArg &Symbol) { void FunctionDumper::dump(const PDBSymbolTypeFunctionArg &Symbol) {
// PDBSymbolTypeFunctionArg is just a shim over the real argument. Just drill // PDBSymbolTypeFunctionArg is just a shim over the real argument. Just drill
// through to the real thing and dump it. // through to the real thing and dump it.
uint32_t TypeId = Symbol.getTypeId(); uint32_t TypeId = Symbol.getTypeId();
auto Type = Symbol.getSession().getSymbolById(TypeId); auto Type = Symbol.getSession().getSymbolById(TypeId);
if (Type) if (!Type)
Printer << "<unknown-type>"; Printer << "<unknown-type>";
else else
Type->dump(*this); Type->dump(*this);
} }
void FunctionDumper::dump(const PDBSymbolTypeTypedef &Symbol) { void FunctionDumper::dump(const PDBSymbolTypeTypedef &Symbol) {
dumpClassParentWithScopeOperator(Symbol, Printer, *this); dumpClassParentWithScopeOperator(Symbol, Printer, *this);
WithColor(Printer, PDB_ColorItem::Type).get() << Symbol.getName(); WithColor(Printer, PDB_ColorItem::Type).get() << Symbol.getName();
Show All 28 Lines