Page MenuHomePhabricator

[PDB] Fixed null pointer dereference
ClosedPublic

Authored by xbolva00 on Apr 29 2019, 2:10 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

xbolva00 created this revision.Apr 29 2019, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 2:10 PM
rnk accepted this revision.Apr 29 2019, 4:38 PM

lgtm, nice

This revision is now accepted and ready to land.Apr 29 2019, 4:38 PM
This revision was automatically updated to reflect the committed changes.
RKSimon added inline comments.
llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
231

@xbolva00 Doesn't this undo the fix I put in at rL359488? We don't want to call dump if Type is null

xbolva00 marked an inline comment as done.Apr 30 2019, 4:21 AM
xbolva00 added inline comments.
llvm/trunk/tools/llvm-pdbutil/PrettyFunctionDumper.cpp
231

Reverted.