Skip TestClassTemplateParameterPack.py on all platforms

[shafik]

Summary

The TestClassTemplateParameterPack.py test does not work for the right reasons. The expressions such as:

expression -- C<int, 16>().isSixteenThirtyTwo()

work only because we are currently pulling all the local variables e.g.:

using $__lldb_local_vars::argc;
using $__lldb_local_vars::argv;
using $__lldb_local_vars::myC;
using $__lldb_local_vars::myLesserC;
using $__lldb_local_vars::myD;
using $__lldb_local_vars::myLesserD;

regardless if we use them in the expression and this causes us to for example to pull C<int,16> into the evaluation context but this is not how it should work. Once we land: https://reviews.llvm.org/D46551

This will no longer work. When clang does the call back it is looking for C but currently the debug information contains C<int,16> etc... So a long-term fix for this would require at least reworking ho that debug information is generated.

[teemperor]

So a long-term fix for this would require at least reworking ho that debug information is generated.

I believe the debug information correct but our lookup is just not finding/loading the necessary AST nodes?

Otherwise I assume the radar is keeping track of the fact that this feature is broken, so LGTM so that we unblock the other reviews.

packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py

7

Nit pick: Isn't there a skip or so that's more expressive than skipIf?

[friss]

We shouldn't skip the whole test, just the expressions that worked for bad reasons. Calling functions on local variables should work, it's just creating the templated objects that is completely broken.

[shafik]

Fred is correct, I mistakenly thought the parts of the test that were working were being covered elsewhere but that is not the case. So I have reworked this change to instead of skipping the whole test to comment out the inline expressions that are specifically broken.

[shafik]

@friss updated the change to only effect those specifically broken.

[friss]

packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp

48–50

This is a little vague. Can you replace it with something like: "Disabling until we do template lookup correctly: http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180507/040689.html"

With this, this LGTM

[shafik]

Updated comment to be more precise.

[shafik]

@friss makes sense, updated comment.

[friss]

LGTM if no one else objects.

[teemperor]

This has been merged as rLLDB359699 but somehow Phabriactor hasn't figured out yet that this needs to be closed. Closing this manually.

packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py

 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
     __file__, globals(), [
         decorators.expectedFailureAll(
-            compiler="gcc"),
-        # rdar://problem/48128064
-        decorators.skipIfDarwin])
+            compiler="gcc")])

packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/main.cpp

 int main (int argc, char const *argv[])
 {
     C<int,16,32> myC;
     C<int,16> myLesserC;
     myC.member = 64;
     (void)C<int,16,32>().isSixteenThirtyTwo();
     (void)C<int,16>().isSixteenThirtyTwo();
     (void)(myC.member != 64);   //% self.expect("expression -- myC", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["64"])
-                                //% self.expect("expression -- C<int, 16>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"])
-                                //% self.expect("expression -- C<int, 16, 32>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"])
                                 //% self.expect("expression -- myLesserC.isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"])
                                 //% self.expect("expression -- myC.isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"])
-   
+                                // Disabling until we do template lookup correctly: http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180507/040689.html
+                                //#% self.expect("expression -- C<int, 16>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"])
+                                //#% self.expect("expression -- C<int, 16, 32>().isSixteenThirtyTwo()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"])
+   
     D<int,int,bool> myD;
     D<int,int> myLesserD;
     myD.member = 64;
     (void)D<int,int,bool>().isIntBool();
     (void)D<int,int>().isIntBool();
     return myD.member != 64;  //% self.expect("expression -- myD", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["64"])
-                                //% self.expect("expression -- D<int, int>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"])
-                                //% self.expect("expression -- D<int, int, bool>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"])
                                 //% self.expect("expression -- myLesserD.isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"])
                                 //% self.expect("expression -- myD.isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"])
+
+                                // See comment above.
+                                //#% self.expect("expression -- D<int, int>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["false"])
+                                //#% self.expect("expression -- D<int, int, bool>().isIntBool()", DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ["true"])
 }