I am trying to move towards much more space-efficient switch statements, using popcnt, as described in PR39013. This is the first in a series.
Also add baseline tests to show effect of later patches.
The previous version of this patch series: D61150
Paths
| Differential D61150
[SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything AbandonedPublic Authored by shawnl on Apr 25 2019, 1:56 PM.
Details
Summary I am trying to move towards much more space-efficient switch statements, using popcnt, as described in PR39013. This is the first in a series. Also add baseline tests to show effect of later patches. The previous version of this patch series: D61150
Diff Detail Event TimelineComment Actions I was confused because the disable-lookup-table.ll not having a datalayout was causing problems. shawnl mentioned this in D61151: [SimpligyCFG] NFC, remove GCD that was only used for powers of two. nikic added inline comments.
nikic added a child revision: D61151: [SimpligyCFG] NFC, remove GCD that was only used for powers of two.Apr 26 2019, 12:24 AM Comment Actions LGTM.
This revision is now accepted and ready to land.Apr 26 2019, 12:36 AM This revision is now accepted and ready to land.Apr 28 2019, 1:20 AM
This revision now requires changes to proceed.May 10 2019, 1:22 PM Comment Actions A few last issues...
This revision now requires changes to proceed.May 13 2019, 12:56 PM shawnl marked an inline comment as done. Comment ActionsI'll get rid of the leftovers.
Comment Actions comment didn't get included.
Revision Contents
Diff 200867 test/Transforms/SimplifyCFG/ARM/cttz-ctlz.ll
test/Transforms/SimplifyCFG/ARM/select-trunc-i64.ll
test/Transforms/SimplifyCFG/ARM/switch-to-lookup-table-constant-expr.ll
test/Transforms/SimplifyCFG/ARM/switch-to-lookup-table.ll
test/Transforms/SimplifyCFG/X86/disable-lookup-table.ll
test/Transforms/SimplifyCFG/X86/speculate-cttz-ctlz.ll
test/Transforms/SimplifyCFG/X86/switch-covered-bug.lltest/Transforms/SimplifyCFG/X86/switch-table-bug.ll
test/Transforms/SimplifyCFG/X86/switch_to_lookup_table.ll
test/Transforms/SimplifyCFG/switch-dead-default.ll
test/Transforms/SimplifyCFG/switch-genfori8.ll
test/Transforms/SimplifyCFG/switch-masked-bits.ll
test/Transforms/SimplifyCFG/switch-on-const-select.ll
test/Transforms/SimplifyCFG/switch-range-to-icmp.ll
test/Transforms/SimplifyCFG/switch-simplify-range.ll
test/Transforms/SimplifyCFG/switch_create-custom-dl.ll
test/Transforms/SimplifyCFG/switch_create.ll
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Here and in the next file: You've generated new CHECK lines with update_test_checks, but the old ones are still there. These need to be manually dropped.