Page MenuHomePhabricator

shawnl (Shawn Landden)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2019, 5:06 AM (77 w, 2 d)

Recent Activity

Jul 19 2020

shawnl planned changes to D83571: [LLVM] New carry-less multiplication instruction llvm.experimental.clmul.
Jul 19 2020, 10:01 AM · Restricted Project
shawnl updated the diff for D83571: [LLVM] New carry-less multiplication instruction llvm.experimental.clmul.

updated docs

Jul 19 2020, 6:46 AM · Restricted Project

Jul 10 2020

Herald added a project to D83571: [LLVM] New carry-less multiplication instruction llvm.experimental.clmul: Restricted Project.
Jul 10 2020, 9:48 AM · Restricted Project
shawnl planned changes to D82527: [PowerPC] custom lowering for CNTPOP(i128).
Jul 10 2020, 9:45 AM · Restricted Project
shawnl planned changes to D83401: [MLIR] CtPop and BitReverse in LLVMIR and Standard (with lowering), and Cttz in LLVMIR.
Jul 10 2020, 9:44 AM · Restricted Project

Jul 8 2020

shawnl added a comment to D83392: Strlen loop idiom recognition.
Jul 8 2020, 11:38 PM · Restricted Project
shawnl updated the summary of D83401: [MLIR] CtPop and BitReverse in LLVMIR and Standard (with lowering), and Cttz in LLVMIR.
Jul 8 2020, 10:14 AM · Restricted Project
Herald added a reviewer for D83401: [MLIR] CtPop and BitReverse in LLVMIR and Standard (with lowering), and Cttz in LLVMIR: ftynse.
Jul 8 2020, 8:20 AM · Restricted Project
shawnl resigned from D81859: [RFC][SimplifyCFG] Allow target to control SpeculateOneExpensiveInst.
Jul 8 2020, 8:17 AM · Restricted Project

Jun 25 2020

shawnl abandoned D63242: [SimplifyCFG] Also use the SwitchReduceRange Threshold for shift operations..
Jun 25 2020, 2:08 AM · Restricted Project
shawnl abandoned D61400: [SelectionDAG] Utilize ARM shift behavior.
Jun 25 2020, 2:08 AM · Restricted Project
shawnl abandoned D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win..
Jun 25 2020, 2:08 AM · Restricted Project
shawnl committed rGde9f842c5567: [PowerPC] add popcount CodeGen test; NFC (authored by shawnl).
[PowerPC] add popcount CodeGen test; NFC
Jun 25 2020, 1:57 AM
shawnl created D82527: [PowerPC] custom lowering for CNTPOP(i128).
Jun 25 2020, 1:56 AM · Restricted Project
shawnl closed D81343: [AArch64] custom lowering for i128 popcount.

This was commited

Jun 25 2020, 1:56 AM · Restricted Project

Jun 24 2020

shawnl added a comment to D81076: [PowerPC] Custom lower rotl v1i128 to vector_shuffle..

It can be done with xor to produce a zero vector, however I can't get the code-gen to generate something that doesn't use the TOC.

Jun 24 2020, 2:40 AM · Restricted Project

Jun 17 2020

shawnl added a comment to rG9ec57cce6240: [AArch64] custom lowering for i128 popcount.
Jun 17 2020, 11:11 PM
shawnl added a comment to D81076: [PowerPC] Custom lower rotl v1i128 to vector_shuffle..

Also non-powers-of-8 can be handled https://godbolt.org/z/6Nww6p

Jun 17 2020, 4:12 PM · Restricted Project

Jun 16 2020

shawnl added a comment to D81076: [PowerPC] Custom lower rotl v1i128 to vector_shuffle..

What about shr and ashl?

Jun 16 2020, 4:58 AM · Restricted Project

Jun 9 2020

shawnl committed rG9ec57cce6240: [AArch64] custom lowering for i128 popcount (authored by shawnl).
[AArch64] custom lowering for i128 popcount
Jun 9 2020, 11:06 PM

Jun 8 2020

shawnl committed rG80ab9345ed97: [AArch64] Add combine-load test; NFC (authored by shawnl).
[AArch64] Add combine-load test; NFC
Jun 8 2020, 3:47 AM
shawnl added inline comments to D81343: [AArch64] custom lowering for i128 popcount.
Jun 8 2020, 3:46 AM · Restricted Project
shawnl committed rG5787ad6c918a: [AArch64] update popcount pre-patch test; NFC (authored by shawnl).
[AArch64] update popcount pre-patch test; NFC
Jun 8 2020, 2:41 AM
shawnl committed rG0fa3a0332790: [AArch64] update popcount pre-patch test, take 2; NFC (authored by shawnl).
[AArch64] update popcount pre-patch test, take 2; NFC
Jun 8 2020, 2:41 AM
shawnl updated the diff for D81343: [AArch64] custom lowering for i128 popcount.

update tests so review is not distracted from another optimization bug

Jun 8 2020, 2:40 AM · Restricted Project

Jun 7 2020

shawnl added inline comments to D81343: [AArch64] custom lowering for i128 popcount.
Jun 7 2020, 2:55 PM · Restricted Project
shawnl added inline comments to D81343: [AArch64] custom lowering for i128 popcount.
Jun 7 2020, 2:55 PM · Restricted Project
shawnl added inline comments to D81343: [AArch64] custom lowering for i128 popcount.
Jun 7 2020, 1:19 PM · Restricted Project
shawnl committed rG53a4bfa80347: [AArch64] add test for large popcount; NFC (authored by shawnl).
[AArch64] add test for large popcount; NFC
Jun 7 2020, 8:29 AM
shawnl created D81343: [AArch64] custom lowering for i128 popcount.
Jun 7 2020, 8:29 AM · Restricted Project

Jun 5 2020

shawnl added inline comments to D81076: [PowerPC] Custom lower rotl v1i128 to vector_shuffle..
Jun 5 2020, 2:02 PM · Restricted Project

Oct 24 2019

shawnl added a comment to D57504: RFC: Prototype & Roadmap for vector predication in LLVM.

Are predicated vector instructions not just a special case of DemandedBits? Why can't we leave out the .vp. intrinsics, and just generate the predicate with DemandedBits? That way you do a predicated vector operation like so (in zig): As the example makes clear, this optimization would have to be guaranteed in order for the generated code to be correct (as the predicate avoids a divide-by-zero error).

Oct 24 2019, 6:43 PM · Restricted Project

Oct 14 2019

Herald added a project to D50685: [AArch64] Support conversion between fp16 and fp128: Restricted Project.

The Zig language doesn't really want to have to special-case this conversion, and would like to see this patch be revisited. It seems to me like some of these reviews were almost accepts. https://github.com/ziglang/zig/issues/3282

Oct 14 2019, 1:06 PM · Restricted Project

Sep 18 2019

shawnl committed rL372295: add Shawn Landden <shawn@git.icu>.
add Shawn Landden <shawn@git.icu>
Sep 18 2019, 8:31 PM

Jul 2 2019

shawnl added a comment to D59254: [RFC] Implementation of Clang randstruct.

My point is that most languages these days that intend to be compiled to machine code want compatibility with the C ABI, and randstruct will be part of that (and can be made compatible between languages by sharing the seed). LLVM knows what a struct is.

Jul 2 2019, 10:40 AM · Restricted Project
shawnl added a comment to D59254: [RFC] Implementation of Clang randstruct.

I think the essential functionality of this patch should be in LLVM and not Clang, so that all front-ends can benefit. Too many generally useful things are in Clang when they should be in LLVM (e.g. C ABI for ARM and x86; ranged switch statements). I opened an upstream bug to discuss this. https://github.com/clang-randstruct/llvm-project/issues/52

Jul 2 2019, 7:54 AM · Restricted Project
Herald added a project to D23155: Power9 - Part-word VSX integer scalar loads/stores and sign extend instructions: Restricted Project.

I think the essential functionality of this patch should be in LLVM and not Clang, so that all front-ends can benefit. To many generally useful things are in Clang when they should be in LLVM (e.g. C ABI for ARM and x86; ranged switch statements). I opened an upstream bug to discuss this. https://github.com/clang-randstruct/llvm-project/issues/52

Jul 2 2019, 7:54 AM · Restricted Project
shawnl added a comment to D23155: Power9 - Part-word VSX integer scalar loads/stores and sign extend instructions.

Oh sorry, wrong bug.

Jul 2 2019, 7:54 AM · Restricted Project

Jun 14 2019

shawnl committed rGf2e60fc4e8c4: [SimpligyCFG] NFC intended, remove GCD that was only used for powers of two (authored by shawnl).
[SimpligyCFG] NFC intended, remove GCD that was only used for powers of two
Jun 14 2019, 9:54 AM
shawnl committed rL363422: [SimpligyCFG] NFC intended, remove GCD that was only used for powers of two.
[SimpligyCFG] NFC intended, remove GCD that was only used for powers of two
Jun 14 2019, 9:54 AM
shawnl abandoned D61132: [builtins] run-time support for sparse maps in llvm.

This will be put directly into LLVM-IR, as llvm can't inline it otherwise anyways.

Jun 14 2019, 8:31 AM · Restricted Project, Restricted Project
shawnl abandoned D61160: [SimplifyCFG] Implement the suggested ctlz transform.

This optimization is not really worth it, for the amount of effort needed to implement it.

Jun 14 2019, 8:31 AM · Restricted Project

Jun 13 2019

shawnl updated the diff for D63242: [SimplifyCFG] Also use the SwitchReduceRange Threshold for shift operations..

fix tests when building tests for ALL architectures

Jun 13 2019, 5:17 PM · Restricted Project
shawnl committed rG24f40858118f: [SimplifyCFG] NFC, update Switch tests as a baseline. (authored by shawnl).
[SimplifyCFG] NFC, update Switch tests as a baseline.
Jun 13 2019, 12:34 PM
shawnl committed rL363319: [SimplifyCFG] NFC, update Switch tests as a baseline..
[SimplifyCFG] NFC, update Switch tests as a baseline.
Jun 13 2019, 12:34 PM

Jun 12 2019

shawnl committed rG8b142bcc3f21: [SimplifyCFG] reverting preliminary Switch patches again (authored by shawnl).
[SimplifyCFG] reverting preliminary Switch patches again
Jun 12 2019, 10:24 PM
shawnl added a reverting change for rG363226dfe897: fix PR7876: If ipsccp decides that a function's address is taken before it…: rG8b142bcc3f21: [SimplifyCFG] reverting preliminary Switch patches again.
Jun 12 2019, 10:24 PM
shawnl added a reverting change for rL363226: [SimplifyCFG] NFC, update Switch tests to better examine successive patches: rL363229: [SimplifyCFG] reverting preliminary Switch patches again.
Jun 12 2019, 10:23 PM
shawnl committed rL363229: [SimplifyCFG] reverting preliminary Switch patches again.
[SimplifyCFG] reverting preliminary Switch patches again
Jun 12 2019, 10:23 PM
shawnl added a reverting change for rL363227: [SimpligyCFG] NFC intended, remove GCD that was only used for powers of two: rL363229: [SimplifyCFG] reverting preliminary Switch patches again.
Jun 12 2019, 10:23 PM
shawnl updated the summary of D63242: [SimplifyCFG] Also use the SwitchReduceRange Threshold for shift operations..
Jun 12 2019, 10:07 PM · Restricted Project
shawnl abandoned D62465: [SimplifyCFG] Also using the SwitchReduceRange Threshold for shift operations..
Jun 12 2019, 10:07 PM · Restricted Project
shawnl committed rG636220e83c2a: [SimpligyCFG] NFC intended, remove GCD that was only used for powers of two (authored by shawnl).
[SimpligyCFG] NFC intended, remove GCD that was only used for powers of two
Jun 12 2019, 9:59 PM
shawnl committed rL363227: [SimpligyCFG] NFC intended, remove GCD that was only used for powers of two.
[SimpligyCFG] NFC intended, remove GCD that was only used for powers of two
Jun 12 2019, 9:59 PM
shawnl updated the summary of D63242: [SimplifyCFG] Also use the SwitchReduceRange Threshold for shift operations..
Jun 12 2019, 9:55 PM · Restricted Project
shawnl created D63242: [SimplifyCFG] Also use the SwitchReduceRange Threshold for shift operations..
Jun 12 2019, 9:55 PM · Restricted Project
shawnl committed rGc54b2011bd07: [SimplifyCFG] NFC, update Switch tests to better examine successive patches (authored by shawnl).
[SimplifyCFG] NFC, update Switch tests to better examine successive patches
Jun 12 2019, 9:49 PM
shawnl committed rL363226: [SimplifyCFG] NFC, update Switch tests to better examine successive patches.
[SimplifyCFG] NFC, update Switch tests to better examine successive patches
Jun 12 2019, 9:48 PM
shawnl committed rGc6cba2957d52: [SimplifyCFG] revert the last commit. (authored by shawnl).
[SimplifyCFG] revert the last commit.
Jun 12 2019, 7:45 PM
shawnl committed rL363223: [SimplifyCFG] revert the last commit..
[SimplifyCFG] revert the last commit.
Jun 12 2019, 7:45 PM
shawnl committed rGf93b99b2b6a4: [SimplifyCFG] NFC, update Switch tests to HEAD so I can (authored by shawnl).
[SimplifyCFG] NFC, update Switch tests to HEAD so I can
Jun 12 2019, 7:22 PM
shawnl committed rL363222: [SimplifyCFG] NFC, update Switch tests to HEAD so I can.
[SimplifyCFG] NFC, update Switch tests to HEAD so I can
Jun 12 2019, 7:22 PM

Jun 11 2019

shawnl added a comment to D63138: [Analysis] add isSplatValue() for vectors in IR.

Looks fine

Jun 11 2019, 9:21 AM · Restricted Project

Jun 4 2019

shawnl committed rG669775f9db79: [Support] make countLeadingZeros() countTrailingZeros() countLeadingOnes() and… (authored by shawnl).
[Support] make countLeadingZeros() countTrailingZeros() countLeadingOnes() and…
Jun 4 2019, 7:51 AM
shawnl committed rL362503: [Support] make countLeadingZeros() countTrailingZeros() countLeadingOnes() and….
[Support] make countLeadingZeros() countTrailingZeros() countLeadingOnes() and…
Jun 4 2019, 7:51 AM
shawnl committed rG2ee9a827ad32: [SimplifyCFG] fix last commit (authored by shawnl).
[SimplifyCFG] fix last commit
Jun 4 2019, 7:31 AM
shawnl committed rL362501: [SimplifyCFG] fix last commit.
[SimplifyCFG] fix last commit
Jun 4 2019, 7:31 AM
shawnl committed rG7f22fecac29e: [SimplifyCFG] NFC; remove bogus test case (authored by shawnl).
[SimplifyCFG] NFC; remove bogus test case
Jun 4 2019, 7:18 AM
shawnl committed rL362499: [SimplifyCFG] NFC; remove bogus test case.
[SimplifyCFG] NFC; remove bogus test case
Jun 4 2019, 7:18 AM
shawnl closed D60859: [SimplifyCFG] remove bogus test case; NFC.
Jun 4 2019, 7:17 AM · Restricted Project

May 26 2019

shawnl committed rG343578759e20: [SimplifyCFG] back out all SwitchInst commits (authored by shawnl).
[SimplifyCFG] back out all SwitchInst commits
May 26 2019, 11:15 AM
shawnl committed rL361736: [SimplifyCFG] back out all SwitchInst commits.
[SimplifyCFG] back out all SwitchInst commits
May 26 2019, 11:13 AM
shawnl added a comment to D62465: [SimplifyCFG] Also using the SwitchReduceRange Threshold for shift operations..

Yes, can you revert them. I really am not very skilled with svn.

May 26 2019, 11:08 AM · Restricted Project
shawnl updated the diff for D62465: [SimplifyCFG] Also using the SwitchReduceRange Threshold for shift operations..

use saturating multiply

May 26 2019, 8:49 AM · Restricted Project
shawnl planned changes to D62465: [SimplifyCFG] Also using the SwitchReduceRange Threshold for shift operations..

this should use saturating multiplication

May 26 2019, 8:48 AM · Restricted Project
shawnl created D62465: [SimplifyCFG] Also using the SwitchReduceRange Threshold for shift operations..
May 26 2019, 8:48 AM · Restricted Project
shawnl committed rG7b883b7ed055: [SimplifyCFG] NFC, one more fixed test from previous push. (authored by shawnl).
[SimplifyCFG] NFC, one more fixed test from previous push.
May 26 2019, 8:27 AM
shawnl committed rL361733: [SimplifyCFG] NFC, one more fixed test from previous push..
[SimplifyCFG] NFC, one more fixed test from previous push.
May 26 2019, 8:27 AM
shawnl closed D61237: [SimplifyCFG] ReduceSwitchRange: Improve on the case where the SubThreshold doesn't trigger.

applied 361728

May 26 2019, 7:47 AM · Restricted Project
shawnl closed D61159: [SimplifyCFG] Run ReduceSwitchRange unconditionally, generalize.

applied 361727

May 26 2019, 7:47 AM · Restricted Project
shawnl closed D61151: [SimpligyCFG] NFC, remove GCD that was only used for powers of two.

applied 361726

May 26 2019, 7:45 AM · Restricted Project
shawnl abandoned D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything.

applied 361725

May 26 2019, 7:45 AM · Restricted Project
shawnl committed rG927fe7328dff: [SimplifyCFG] NFC, fix failing tests from last patches. (authored by shawnl).
[SimplifyCFG] NFC, fix failing tests from last patches.
May 26 2019, 7:44 AM
shawnl closed D60823: [Support] make countLeadingZeros() countTrailingZeros() countLeadingOnes() and countTrailingOnes() return unsigned.

applied r361724

May 26 2019, 7:44 AM · Restricted Project
shawnl committed rL361730: [SimplifyCFG] NFC, fix failing tests from last patches..
[SimplifyCFG] NFC, fix failing tests from last patches.
May 26 2019, 7:44 AM
shawnl committed rGfa91ab85d9f8: [SimplifyCFG] ReduceSwitchRange: Improve on the case where the SubThreshold… (authored by shawnl).
[SimplifyCFG] ReduceSwitchRange: Improve on the case where the SubThreshold…
May 26 2019, 6:56 AM
shawnl committed rG30111c786f7c: [SimplifyCFG] Run ReduceSwitchRange unconditionally, generalize (authored by shawnl).
[SimplifyCFG] Run ReduceSwitchRange unconditionally, generalize
May 26 2019, 6:56 AM
shawnl committed rL361728: [SimplifyCFG] ReduceSwitchRange: Improve on the case where the SubThreshold….
[SimplifyCFG] ReduceSwitchRange: Improve on the case where the SubThreshold…
May 26 2019, 6:53 AM
shawnl committed rL361727: [SimplifyCFG] Run ReduceSwitchRange unconditionally, generalize.
[SimplifyCFG] Run ReduceSwitchRange unconditionally, generalize
May 26 2019, 6:52 AM
shawnl committed rG444eaaf1cce2: [SimpligyCFG] NFC, remove GCD that was only used for powers of two (authored by shawnl).
[SimpligyCFG] NFC, remove GCD that was only used for powers of two
May 26 2019, 6:52 AM
shawnl committed rG50c73a044f22: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes… (authored by shawnl).
[SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes…
May 26 2019, 6:51 AM
shawnl committed rL361726: [SimpligyCFG] NFC, remove GCD that was only used for powers of two.
[SimpligyCFG] NFC, remove GCD that was only used for powers of two
May 26 2019, 6:51 AM
shawnl committed rGb7cc093db28c: [Support] make countLeadingZeros() and countTrailingZeros() return unsigned (authored by shawnl).
[Support] make countLeadingZeros() and countTrailingZeros() return unsigned
May 26 2019, 6:51 AM
shawnl committed rL361725: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes….
[SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes…
May 26 2019, 6:51 AM
shawnl committed rL361724: [Support] make countLeadingZeros() and countTrailingZeros() return unsigned.
[Support] make countLeadingZeros() and countTrailingZeros() return unsigned
May 26 2019, 6:51 AM

May 22 2019

shawnl updated the diff for D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything.

remove line nikic mentioned

May 22 2019, 8:34 PM · Restricted Project

May 19 2019

shawnl added inline comments to D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win..
May 19 2019, 5:16 AM · Restricted Project

May 13 2019

shawnl updated the diff for D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything.
May 13 2019, 4:58 PM · Restricted Project
shawnl planned changes to D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything.

I'll get rid of the leftovers.

May 13 2019, 4:17 PM · Restricted Project
shawnl added a comment to D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything.

comment didn't get included.

May 13 2019, 4:17 PM · Restricted Project