Even if one bit is defined, the code is not clear what it is suppose to do.
See 41530
Differential D60859
[SimplifyCFG] remove bogus test case; NFC shawnl on Apr 18 2019, 2:40 AM. Authored by
Details Even if one bit is defined, the code is not clear what it is suppose to do. See 41530
Diff Detail
Event TimelineComment Actions Patch doesn't seem to be against master, here's how the test looks right now: https://github.com/llvm-mirror/llvm/blob/master/test/Transforms/SimplifyCFG/switch-dead-default.ll#L160 In any case, agree that the test doesn't make sense and we should drop it. The test wants to assert that some bits are undef, but that's not what the IR does and I don't think it's even possible to do that in any meaningful way. It was added in D12497, so @reames might want to double check. Comment Actions Most bots on the waterfall are unhappy after this, e.g. http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/25030/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aswitch-dead-default.ll -- can you fix quickly, or if it takes a while revert? |