[utils] allow opt-8, opt-9 distro

[shawnl]

Summary

allow using Debian's opt-8, opt-9 with update_test_checks.py

[lebedev.ri]

Why?
It doesn't make sense to generate check lines with anything other than the newly-built opt.

[RKSimon]

In D61148#1479407, @lebedev.ri wrote:

Why?
It doesn't make sense to generate check lines with anything other than the newly-built opt.

Same thoughts here - I'm not against this change but first I'd like some context as to why its useful.

[MaskRay]

Same thoughts. The version of the opt command must be in sync with the version of tests. Since this utility is only useful for top of trunk, an older opt is not useful.

[shawnl]

Yeah sorry. I wanted to use these http://apt.llvm.org/ to sanity check myself. While you can always just use opt directly, using this tool make git diff work.

[RKSimon]

I have not objection @MaskRay can you approve if you're happy with this?

[MaskRay]

I think there may be some value to compare how releases evolve..

utils/update_test_checks.py

71 ↗

(On Diff #196722)

We can probably use if not re.match(r'^opt(-\d+)?$', opt_basename):

[MaskRay]

Shawn asked me to commit on behalf of him :)

llvm/trunk/utils/update_test_checks.py

def main():
   parser.add_argument(
       '--function', help='The function in the test file to update')
   parser.add_argument('tests', nargs='+')
   args = parser.parse_args()
 
   autogenerated_note = (ADVERT + 'utils/' + os.path.basename(__file__))
 
   opt_basename = os.path.basename(args.opt_binary)
-  if (opt_basename != "opt"):
+  if not re.match(r'^opt(-\d+)?$', opt_basename):
     print('ERROR: Unexpected opt name: ' + opt_basename, file=sys.stderr)
     sys.exit(1)
+  opt_basename = 'opt'
 
   test_paths = [test for pattern in args.tests for test in glob.glob(pattern)]
   for test in test_paths:
     if args.verbose:
       print('Scanning for RUN lines in test file: %s' % (test,), file=sys.stderr)
     with open(test) as f:
       input_lines = [l.rstrip() for l in f]