llvm::Regex is really slow, and regex evaluation during preamble indexing was
showing up as 25% on a profile of clangd in a codebase with large preambles.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCTE Clang Tools Extra
Event Timeline
Comment Actions
LGTM (see the comment about a typo, though)
clangd/index/SymbolCollector.cpp | ||
---|---|---|
669 | A typo? Should it be include. |
clangd/index/SymbolCollector.cpp | ||
---|---|---|
669 | it's meant to match "include" or "including". I'll add a comment. |
clangd/index/SymbolCollector.cpp | ||
---|---|---|
669 | Makes sense. Comment would work, thanks! |
A typo? Should it be include.