This is an archive of the discontinued LLVM Phabricator instance.

lib/Header: Fix Visual Studio builds
ClosedPublic

Authored by tstellar on Apr 23 2019, 7:34 PM.

Details

Summary

This is a follow up to r355253, which inadvertently broke Visual
Studio builds by trying to copy files from CMAKE_CFG_INTDIR.

See https://reviews.llvm.org/D58537#inline-532492

Diff Detail

Repository
rC Clang

Event Timeline

tstellar created this revision.Apr 23 2019, 7:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2019, 7:34 PM
Herald added a subscriber: mgorny. · View Herald Transcript
smeenai accepted this revision.Apr 24 2019, 9:56 AM

LGTM

This would break if someone does a debug and release build simultaneously, the copies occur simultaneously and the filesystem gets unhappy, That seems fairly contrived though, and this is also restoring the behavior before your previous change.

This revision is now accepted and ready to land.Apr 24 2019, 9:56 AM
This revision was automatically updated to reflect the committed changes.