This is an archive of the discontinued LLVM Phabricator instance.

[Ubsan] Fix the missing_return.cpp test to pass on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Nov 3 2014, 7:31 AM.

Diff Detail

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Ubsan] Fix the missing_return.cpp test to pass on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
kcc edited edge metadata.Nov 3 2014, 10:34 AM
kcc added a subscriber: glider.

I'd like to remove the difference between OSes, not increase it.
glider@, can we remove the Darwin-specific check here?

samsonov accepted this revision.Nov 3 2014, 11:30 AM
samsonov edited edge metadata.

LGTM for now. I'd really like to work on Mac fixes for stacktraces in UBSan later.

This revision is now accepted and ready to land.Nov 3 2014, 11:30 AM
kcc accepted this revision.Nov 3 2014, 11:48 AM
kcc edited edge metadata.

LGTM then...

Diffusion closed this revision.Nov 10 2014, 7:18 AM
Diffusion updated this revision to Diff 15979.

Closed by commit rL221597 (authored by vkutuzov).