This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove redundant conditionals for Apple platforms
ClosedPublic

Authored by ldionne on Apr 17 2019, 3:25 PM.

Details

Summary

In a bunch of places, we used to check whether LIBCXX_BUILDING_LIBCXXABI
is defined OR we're building for an Apple platform. This used to
be necessary in a time when Apple's build script did NOT define
LIBCXX_BUILDING_LIBCXXABI. However this is not relevant anymore
since Apple's build does define LIBCXX_BUILDING_LIBCXXABI.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Apr 17 2019, 3:25 PM
ldionne accepted this revision.Apr 23 2019, 7:02 AM

I'll try this out and back out if it breaks something -- I tested locally but we never know.

This revision is now accepted and ready to land.Apr 23 2019, 7:02 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2019, 7:03 AM