This is an archive of the discontinued LLVM Phabricator instance.

Differential D60684

[llvm-readobj] Reapply: Improve error message for --string-dump
ClosedPublic

Authored by StephenTozer on Apr 15 2019, 3:47 AM.

Details

Reviewers
jhenderson
rupprecht
grimar
Higuoxing
Summary

This is a resubmission of a previous patch that caused test failures, with only the fixes for the relevant tests included.

Previous review with full changelist: https://reviews.llvm.org/D59946

Diff Detail

Repository
rL LLVM

Event Timeline

StephenTozer created this revision.Apr 15 2019, 3:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 3:47 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jhenderson accepted this revision.Apr 15 2019, 3:55 AM

LGTM. I'm slightly surprised the latter checks needed modifying (it's okay to though), but aside from that, this is fine.

This revision is now accepted and ready to land.Apr 15 2019, 3:55 AM
Higuoxing accepted this revision.Apr 15 2019, 4:01 AM

LGTM.

Higuoxing added a comment.Sep 6 2019, 10:05 PM

Friendly ping @StephenTozer? Seems that this patch has been accepted long time ago. Is this patch still valid? Could you please commit this?

StephenTozer closed this revision.Sep 9 2019, 2:56 AM

This one has been merged in; it probably didn't get picked up because this review doesn't include the other changes that were reapplied in the patch.

Merged by commit r358395: 19bb1d5739b4d0a4921717609e8615d20097b96e

Revision Contents

PathSize
llvm/
test/
Object/
6 lines

Diff 195122

llvm/test/Object/corrupt.test

Show All 17 Lines
SYMNAME: invalid string offset SYMNAME: invalid string offset
// Version index in .gnu.version overflows the version map. // Version index in .gnu.version overflows the version map.
RUN: not llvm-readobj %p/Inputs/corrupt-version.elf-x86_64 -dt \ RUN: not llvm-readobj %p/Inputs/corrupt-version.elf-x86_64 -dt \
RUN: 2>&1 | FileCheck --check-prefix=VER %s RUN: 2>&1 | FileCheck --check-prefix=VER %s
VER: Error reading file: Invalid version entry. VER: error: Invalid version entry
// The file is missing the dynamic string table but has references to it. // The file is missing the dynamic string table but has references to it.
RUN: not llvm-readobj -dynamic-table %p/Inputs/corrupt-invalid-strtab.elf.x86-64 \ RUN: not llvm-readobj -dynamic-table %p/Inputs/corrupt-invalid-strtab.elf.x86-64 \
RUN: 2>&1 | FileCheck --check-prefix=STRTAB %s RUN: 2>&1 | FileCheck --check-prefix=STRTAB %s
STRTAB: Invalid dynamic string table reference STRTAB: Invalid dynamic string table reference
Show All 22 Lines
DYN-TABLE-SIZE: Invalid entity size DYN-TABLE-SIZE: Invalid entity size
RUN: not llvm-readobj -dyn-relocations \ RUN: not llvm-readobj -dyn-relocations \
RUN: %p/Inputs/corrupt-invalid-dynamic-table-offset.elf.x86-64 2>&1 | \ RUN: %p/Inputs/corrupt-invalid-dynamic-table-offset.elf.x86-64 2>&1 | \
RUN: FileCheck --check-prefix=DYN-TABLE-OFFSET %s RUN: FileCheck --check-prefix=DYN-TABLE-OFFSET %s
DYN-TABLE-OFFSET: Invalid data was encountered while parsing the file. DYN-TABLE-OFFSET: error: Invalid data was encountered while parsing the file
RUN: not llvm-readobj -dyn-relocations \ RUN: not llvm-readobj -dyn-relocations \
RUN: %p/Inputs/corrupt-invalid-dynamic-table-too-large.elf.x86-64 2>&1 | \ RUN: %p/Inputs/corrupt-invalid-dynamic-table-too-large.elf.x86-64 2>&1 | \
RUN: FileCheck --check-prefix=DYN-TABLE-TOO-LARGE %s RUN: FileCheck --check-prefix=DYN-TABLE-TOO-LARGE %s
DYN-TABLE-TOO-LARGE: Invalid data was encountered while parsing the file. DYN-TABLE-TOO-LARGE: error: Invalid data was encountered while parsing the file