Page MenuHomePhabricator

[llvm-readobj] Reapply: Improve error message for --string-dump
ClosedPublic

Authored by StephenTozer on Apr 15 2019, 3:47 AM.

Details

Summary

This is a resubmission of a previous patch that caused test failures, with only the fixes for the relevant tests included.

Previous review with full changelist: https://reviews.llvm.org/D59946

Diff Detail

Repository
rL LLVM

Event Timeline

StephenTozer created this revision.Apr 15 2019, 3:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 3:47 AM
jhenderson accepted this revision.Apr 15 2019, 3:55 AM

LGTM. I'm slightly surprised the latter checks needed modifying (it's okay to though), but aside from that, this is fine.

This revision is now accepted and ready to land.Apr 15 2019, 3:55 AM

Friendly ping @StephenTozer? Seems that this patch has been accepted long time ago. Is this patch still valid? Could you please commit this?

StephenTozer closed this revision.Sep 9 2019, 2:56 AM

This one has been merged in; it probably didn't get picked up because this review doesn't include the other changes that were reapplied in the patch.

Merged by commit r358395: 19bb1d5739b4d0a4921717609e8615d20097b96e