There is no test for PRC, OS and RSV kind of symbols. Does anyone know how to generate them?
Use yaml2obj, with an explicit section index, but actually you don't need to test them as they are already tested by test/tools/llvm-readobj/elf-symbol-shndx.test.
|1 ↗||(On Diff #194869)|
Won't this generate COFF output on Windows hosts? I think you need to specify a target triple, and probably a REQUIRES: x86 or similar.
Okay, basically looks fine. Just a couple of small comments.
|1 ↗||(On Diff #194885)|
A brief comment at the start of test describing what this test is testing might help future readers.
|20 ↗||(On Diff #194885)|
Actually, with the positive CHECKS, I don't think you need the negative ones.
|25 ↗||(On Diff #194885)|
Nit: Too many blank lines at EOF?
|8 ↗||(On Diff #194889)|
My only concern with this patch: how long does this test take to run, specifically, how long does llvm-mc take to generate a file with this many sections? I've run into a similar issue in the past, where I wanted to create a test like this, but generating the test file from something like this took an absurd amount of time.
If it's fast, that'd be great (and if so, this patch LGTM). Maybe I'll dust off my old semi-abandoned patch and try to use this...
My only concern with this patch: how long does this test take to run, specifically, how long does llvm-mc take to generate a file with this many sections?
4 seconds in debug build (Core-i7 2600K)