Page MenuHomePhabricator

[TSan][libdispatch] Replace NSTemporaryDirectory in tests
ClosedPublic

Authored by yln on Apr 11 2019, 4:42 PM.

Details

Summary

After this change, most tests don't have a dependency on Foundation.

Note: To hold the file name tempnam allocates a new buffer. We leak
this buffer (omit the free), but I don't think we need to care.

Event Timeline

yln created this revision.Apr 11 2019, 4:42 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 11 2019, 4:42 PM
Herald added subscribers: llvm-commits, Restricted Project, kubamracek. · View Herald Transcript
yln edited the summary of this revision. (Show Details)Apr 11 2019, 4:45 PM
yln added reviewers: kubamracek, dcoughlin.
kubamracek accepted this revision.Apr 12 2019, 1:03 PM
kubamracek added inline comments.
compiler-rt/test/tsan/Darwin/gcd-fd.mm
4

Do we want to remove this now?

This revision is now accepted and ready to land.Apr 12 2019, 1:03 PM
yln marked 2 inline comments as done.Apr 12 2019, 1:08 PM
yln added inline comments.
compiler-rt/test/tsan/Darwin/gcd-fd.mm
4

Yes, I will do this plus renaming/moving the tests in a separate commit.

This revision was automatically updated to reflect the committed changes.