This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Use SpacesBeforeTrailingComments for "option" directive
ClosedPublic

Authored by dchai on Apr 10 2019, 3:07 PM.

Details

Summary

AnnotatingParser::next() is needed to implicitly set TT_BlockComment
versus TT_LineComment. On most other paths through
AnnotatingParser::parseLine(), all tokens are consumed to achieve that.
This change updates one place where this wasn't done.

Diff Detail

Repository
rC Clang

Event Timeline

dchai created this revision.Apr 10 2019, 3:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2019, 3:07 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
krasimir accepted this revision.Apr 11 2019, 4:41 AM

Thank you!

This revision is now accepted and ready to land.Apr 11 2019, 4:41 AM
dchai removed a subscriber: cfe-commits.Apr 11 2019, 8:05 PM

Can someone please merge this for me? I don't have commit access.

I'll merge this.

This revision was automatically updated to reflect the committed changes.