Page MenuHomePhabricator

dchai (Donald Chai)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 20 2019, 7:27 PM (26 w, 3 d)

Recent Activity

May 9 2019

dchai added a reviewer for D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"": klimek.
May 9 2019, 5:49 PM · Restricted Project

May 7 2019

dchai accepted D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 7 2019, 10:14 PM · Restricted Project
dchai updated the diff for D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".

no-op to try to get rid of "Changes Planned" state

May 7 2019, 10:14 PM · Restricted Project
dchai accepted D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
May 7 2019, 10:04 PM · Restricted Project
dchai planned changes to D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".

Hi, can someone please merge this on my behalf? I don't have commit access.

May 7 2019, 9:55 PM · Restricted Project

Apr 29 2019

dchai added reviewers for D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"": sammccall, MyDeveloperDay.
Apr 29 2019, 6:19 PM · Restricted Project

Apr 23 2019

dchai added a comment to D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".

Friendly ping.

Apr 23 2019, 5:07 PM · Restricted Project

Apr 13 2019

dchai created D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Apr 13 2019, 9:31 PM · Restricted Project
dchai added a reverting change for rL356912: Revert "[clang-format] Keep protobuf "package" statement on one line": D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line"".
Apr 13 2019, 9:31 PM

Apr 11 2019

dchai updated subscribers of D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.

Can someone please merge this for me? I don't have commit access.

Apr 11 2019, 8:06 PM · Restricted Project

Apr 10 2019

dchai created D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive.
Apr 10 2019, 3:07 PM · Restricted Project

Mar 25 2019

dchai added a comment to D59627: [clang-format] Keep protobuf "package" statement on one line.

Just to confirm, the regression is in the number of spaces before a trailing comment?

Mar 25 2019, 1:23 PM · Restricted Project, Restricted Project

Mar 21 2019

dchai added a comment to D59629: [clang-format] correctly format protobuf fields named "enum"..

I don't have commit access; can someone please merge this on my behalf?

Mar 21 2019, 3:45 PM · Restricted Project, Restricted Project, Restricted Project
dchai updated the diff for D59627: [clang-format] Keep protobuf "package" statement on one line.

Use "isOneOf" instead of two calls to "is".

Mar 21 2019, 10:23 AM · Restricted Project, Restricted Project

Mar 20 2019

dchai created D59629: [clang-format] correctly format protobuf fields named "enum"..
Mar 20 2019, 9:35 PM · Restricted Project, Restricted Project, Restricted Project
dchai added a reviewer for D59627: [clang-format] Keep protobuf "package" statement on one line: krasimir.
Mar 20 2019, 7:56 PM · Restricted Project, Restricted Project
dchai created D59627: [clang-format] Keep protobuf "package" statement on one line.
Mar 20 2019, 7:41 PM · Restricted Project, Restricted Project