Page MenuHomePhabricator

[pstl] Fix header inclusion order failures
ClosedPublic

Authored by rodgert on Apr 10 2019, 11:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

rodgert created this revision.Apr 10 2019, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2019, 11:30 AM
ldionne accepted this revision.Apr 10 2019, 11:43 AM
This revision is now accepted and ready to land.Apr 10 2019, 11:43 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2019, 11:52 AM

I have no objections in general..
But let add the line

std::cout << done() << std::endl;

before return 0;

  1. our test system searching for a special marker in a log - "done" or "passed"; otherwise a test is failed.
  2. to be consistent with the rest test units.

I have no objections in general..
But let add the line

std::cout << done() << std::endl;

before return 0;

  1. our test system searching for a special marker in a log - "done" or "passed"; otherwise a test is failed.
  2. to be consistent with the rest test units.

Would it be possible to have your test system check for a non-zero exit code as a failure indication? This is that CMake and lit use, and we're not going to keep all these cout calls there forever.

Eventually, I tend to that keeping "cout" code is redundant , just "return 0" is enough.
We will try to re-config our test system to accept just returning zero;

Eventually, I tend to that keeping "cout" code is redundant , just "return 0" is enough.
We will try to re-config our test system to accept just returning zero;

That would be great! Another nice side effect of this is that we could stop using <iostreams> everywhere, which is both not really in line with the rest of the libc++ test suite, and also extremely costly in terms of compilation time. I'm sure you've noticed that the tests were not exactly fast to compile :-).