This is an archive of the discontinued LLVM Phabricator instance.

Differential D60471

Fixed possible out of bound array access
ClosedPublic

Authored by AndreyChurbanov on Apr 9 2019, 10:18 AM.

Details

Reviewers
jlpeyton
hbae
tlwilmar
Commits
rOMP358181: Fixed possible out of bound array access.
rG705384be9741: Fixed possible out of bound array access.
rL358181: Fixed possible out of bound array access.
Summary

The check of index moved to before the write to array.

Diff Detail

Repository
rL LLVM

Event Timeline

AndreyChurbanov created this revision.Apr 9 2019, 10:18 AM
Herald added subscribers: openmp-commits, jdoerfert. · View Herald TranscriptApr 9 2019, 10:18 AM
hbae accepted this revision.Apr 11 2019, 6:36 AM

LGTM.

This revision is now accepted and ready to land.Apr 11 2019, 6:36 AM
Closed by commit rL358181: Fixed possible out of bound array access. (authored by achurbanov). · Explain WhyApr 11 2019, 8:02 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2019, 8:02 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
openmp/
trunk/
runtime/
src/
4 lines

Diff 194694

openmp/trunk/runtime/src/kmp_settings.cpp

Show First 20 Lines • Show All 4,456 Lines • ▼ Show 20 Linesstatic void __kmp_stg_parse_hw_subset(char const *name, char const *value,
if (len == 0 || mlen == 0) if (len == 0 || mlen == 0)
goto err; // contents is either empty or too long goto err; // contents is either empty or too long
input[len] = '\0'; input[len] = '\0';
__kmp_hws_requested = 1; // mark that subset requested __kmp_hws_requested = 1; // mark that subset requested
// Split by delimiter // Split by delimiter
pos = input; pos = input;
components[level++] = pos; components[level++] = pos;
while ((pos = strchr(pos, ','))) { while ((pos = strchr(pos, ','))) {
if (level >= MAX_T_LEVEL)
goto err; // too many components provided
*pos = '\0'; // modify input and avoid more copying *pos = '\0'; // modify input and avoid more copying
components[level++] = ++pos; // expect something after "," components[level++] = ++pos; // expect something after ","
if (level > MAX_T_LEVEL)
goto err; // too many components provided
} }
// Check each component // Check each component
for (int i = 0; i < level; ++i) { for (int i = 0; i < level; ++i) {
int offset = 0; int offset = 0;
int num = atoi(components[i]); // each component should start with a number int num = atoi(components[i]); // each component should start with a number
if ((pos = strchr(components[i], '@'))) { if ((pos = strchr(components[i], '@'))) {
offset = atoi(pos + 1); // save offset offset = atoi(pos + 1); // save offset
*pos = '\0'; // cut the offset from the component *pos = '\0'; // cut the offset from the component
▲ Show 20 Lines • Show All 1,334 Lines • Show Last 20 Lines