Page MenuHomePhabricator

[libunwind] Export the weak alias in Mach-O
ClosedPublic

Authored by phosek on Apr 3 2019, 8:24 PM.

Details

Summary

This is not necessary for ELF since .globl and .weak are mutually
exclusive, but is necessary for Mach-O otherwise the symbol isn't
visible externally.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Apr 3 2019, 8:24 PM
phosek added a comment.Apr 3 2019, 8:25 PM

This addresses the issue that was introduced in r357640 and detected by our 2-stage LTO builder.

mcgrathr accepted this revision.Apr 3 2019, 8:25 PM

Lgtm

This revision is now accepted and ready to land.Apr 3 2019, 8:25 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 8:35 PM