Page MenuHomePhabricator

Add clangTooling dependency to fix the build.
AbandonedPublic

Authored by ymandel on Apr 3 2019, 9:59 AM.

Details

Reviewers
ABataev
Summary

Fixes https://reviews.llvm.org/D59371, which broke the build for shared libraries.

Event Timeline

ymandel created this revision.Apr 3 2019, 9:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 9:59 AM

Nope, it won't work. There is a cyclic dependency, unfortunately. clangTooling depends on clangToolingRefactor already. You need to revert your commit and refactor it to remove the cyclic dependency.

Nope, it won't work. There is a cyclic dependency, unfortunately. clangTooling depends on clangToolingRefactor already. You need to revert your commit and refactor it to remove the cyclic dependency.

I see. I've never reverted before and I can't seem to find any instructions for doing so (only some offhand mentions). If there's a doc on this, can you please link me to it?

Thanks!

I can revert it for you, if you want

Reverted in r357612

ymandel abandoned this revision.Apr 3 2019, 10:51 AM