This is an archive of the discontinued LLVM Phabricator instance.

Differential D60168

[test-suite,CUDA] Add #include <stdio.h> to test_round.cu to fix a build error.
ClosedPublic

Authored by bixia on Apr 2 2019, 5:51 PM.

Details

Reviewers
tra
Commits
rOLDT357622: [test-suite,CUDA] Add #include <stdio.h> to test_round.cu to fix a build error.
rL357622: [test-suite,CUDA] Add #include <stdio.h> to test_round.cu to fix a build error.

Diff Detail

Event Timeline

bixia created this revision.Apr 2 2019, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2019, 5:51 PM
Herald added subscribers: llvm-commits, jlebar. · View Herald Transcript
bixia added a reviewer: tra.Apr 2 2019, 5:51 PM
Harbormaster completed remote builds in B29983: Diff 193406.Apr 2 2019, 5:53 PM
tra accepted this revision.Apr 3 2019, 10:30 AM
tra added inline comments.
External/CUDA/test_round.cu
8–9

I think you can remove iostream -- the file does not seem to use anything from it.

This revision is now accepted and ready to land.Apr 3 2019, 10:30 AM
bixia updated this revision to Diff 193556.Apr 3 2019, 11:48 AM

Remove iostream.

Harbormaster completed remote builds in B30017: Diff 193556.Apr 3 2019, 11:51 AM
Closed by commit rL357622: [test-suite,CUDA] Add #include <stdio.h> to test_round.cu to fix a build error. (authored by bixia1). · Explain WhyApr 3 2019, 12:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
External/
CUDA/
2 lines

Diff 193556

External/CUDA/test_round.cu

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include <iostream>
#include <cassert> #include <cassert>
traUnsubmitted
Not Done
ReplyInline Actions

I think you can remove iostream -- the file does not seem to use anything from it.

tra: I think you can remove iostream -- the file does not seem to use anything from it.
#include <stdio.h>
// Test the implementation of llvm intrinsic round. In particular, when the // Test the implementation of llvm intrinsic round. In particular, when the
// source is equidistant between two integers, it rounds away from zero. // source is equidistant between two integers, it rounds away from zero.
// //
// In CUDA libdevice, the implementation of round separates the values into // In CUDA libdevice, the implementation of round separates the values into
// three regions and uses a region specific rounding method to calculate // three regions and uses a region specific rounding method to calculate
// the result: // the result:
// abs(x) <= 0.5 // abs(x) <= 0.5
Show All 36 Lines