Page MenuHomePhabricator

[Process] Use early returns in Process::WriteMemory (NFC)
ClosedPublic

Authored by JDevlieghere on Apr 1 2019, 1:14 PM.

Details

Summary

I found the code of Process::WriteMemory particularly hard to follow when reviewing Ismail's change in D60022. This simplifies the code and hopefully prevents similar oversights in the future.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.Apr 1 2019, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2019, 1:14 PM
Herald added a subscriber: abidh. · View Herald Transcript
JDevlieghere edited the summary of this revision. (Show Details)Apr 1 2019, 1:14 PM
davide added a comment.Apr 1 2019, 1:25 PM

LGTM. Med, what do you think?

mib added a comment.Apr 1 2019, 1:29 PM
This comment was removed by mib.
mib accepted this revision.Apr 1 2019, 1:32 PM

LGTM!

This revision is now accepted and ready to land.Apr 1 2019, 1:32 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2019, 1:41 PM