This is an archive of the discontinued LLVM Phabricator instance.

Add execution header
AbandonedPublic

Authored by zoecarver on Mar 30 2019, 9:45 AM.

Details

Summary

Adds the execution header and all members.

Diff Detail

Event Timeline

zoecarver created this revision.Mar 30 2019, 9:45 AM
mclow.lists requested changes to this revision.Mar 30 2019, 1:32 PM

I think we're going to get this from the work that @ldionne and Thomas Rodgers are doing on the pstl project. You should check with them.

For future reference - adding a new header file is more complicated than this.

  • You need to update the "double include tester" - test/libcxx/double_include.sh.cpp
  • You need to put an entry in the module map - include/module.modulemap
This revision now requires changes to proceed.Mar 30 2019, 1:32 PM

Yes, indeed, this will be provided by the PSTL.

@ldionne Okay, great. I assume you mean this PSTL? Is that ever merged into libc++? Also, it doesn't look like PSTL contains any of the execution policies (or is_execution_policy). Should I make a patch to that repository, or would you rather implement those yourself?

@mclow.lists Thanks for the reference on adding header files.

@ldionne Okay, great. I assume you mean this PSTL? Is that ever merged into libc++?

Not right now, but I'm working on integrating it into libc++.

Also, it doesn't look like PSTL contains any of the execution policies (or is_execution_policy). Should I make a patch to that repository, or would you rather implement those yourself?

See https://github.com/llvm-mirror/pstl/blob/master/include/pstl/internal/execution_defs.h#L23

I see, thanks (didn't find that file for some reason). Let me know if you want any help implementing it into libc++ :)

zoecarver abandoned this revision.Jun 6 2019, 8:13 PM

@ldionne's got this :)