This is an archive of the discontinued LLVM Phabricator instance.

[opt-viewer] Make filter_=None by default in get_remarks and gather_results
ClosedPublic

Authored by paquette on Mar 27 2019, 11:09 AM.

Details

Summary

Right now, if you try to use optdiff.py on any opt records, it will fail because its calls to gather_results weren't updated to support filtering.

Since filters are supposed to be optional, this makes them None by default in get_remarks and in gather_results. This allows other tools that don't support filtering to still use the functions as is.

Diff Detail

Event Timeline

paquette created this revision.Mar 27 2019, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 11:09 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
anemet accepted this revision.Mar 27 2019, 11:10 AM

LGTM, thanks for fixing this!

This revision is now accepted and ready to land.Mar 27 2019, 11:10 AM
This revision was automatically updated to reflect the committed changes.