Page MenuHomePhabricator

[PR41247] Fixed parsing of private keyword in C++
ClosedPublic

Authored by Anastasia on Mar 27 2019, 6:00 AM.

Details

Summary

In C++ private shouldn't be parsed as a valid address space keyword.

This only fixes C++ part, in OpenCL we should still prevent ICE on the reported code example, but I will fix it separately.

@jsji thanks for filing the bug!

Diff Detail

Repository
rL LLVM

Event Timeline

Anastasia created this revision.Mar 27 2019, 6:00 AM

Otherwise LGTM.

test/SemaOpenCLCXX/private-access-specifier.cpp
2 ↗(On Diff #192429)

Please include a comment explaining why this test file is in test/SemaOpenCLCXX/ (because it's testing a regression in general code arising from an OpenCL C++ feature).

Extended test case and explained the intention of the test.

rjmccall accepted this revision.Mar 27 2019, 12:07 PM
This revision is now accepted and ready to land.Mar 27 2019, 12:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 4:47 AM