Page MenuHomePhabricator

AMDGPU: Fix areLoadsFromSameBasePtr for DS atomics
ClosedPublic

Authored by arsenm on Mar 26 2019, 3:20 PM.

Details

Reviewers
rampitec
hakzsam
Summary

The offset operand index is different for atomics.

Diff Detail

Event Timeline

arsenm created this revision.Mar 26 2019, 3:20 PM
arsenm updated this revision to Diff 192375.Mar 26 2019, 3:22 PM

Fix run line

This revision is now accepted and ready to land.Mar 26 2019, 3:25 PM

Thanks for the quick fix Matt!

arsenm marked 2 inline comments as done.Mar 27 2019, 7:21 AM
arsenm added inline comments.
lib/Target/AMDGPU/SIInstrInfo.cpp
178–179

These should use the NumDefs from the instr desc in case the no-ret atomics are used, although those are inserted later currently

181

The index used needs to be fixed for inst 1

arsenm closed this revision.Mar 27 2019, 8:39 AM

r357073