Page MenuHomePhabricator

PEI: Delay checking requiresFrameIndexReplacementScavenging
ClosedPublic

Authored by arsenm on Mar 26 2019, 12:37 PM.

Details

Summary

Currently this is called before the frame size is set on the
function. For AMDGPU, the scavenger is used for large frames where
part of the offset needs to be materialized in a register, so
estimating the frame size is useful for knowing whether the scavenger
is useful.

Diff Detail

Event Timeline

arsenm created this revision.Mar 26 2019, 12:37 PM

It would be good to have a test case for this, but I assume you're planning on changing SIRegisterInfo::requiresFrameIndexReplacementScavenging? Maybe you can merge both patches since AMDGPU seems to be the only user of the hook.

It would be good to have a test case for this, but I assume you're planning on changing SIRegisterInfo::requiresFrameIndexReplacementScavenging? Maybe you can merge both patches since AMDGPU seems to be the only user of the hook.

I usually try to separate the target specific part when possible: D59840

thegameg accepted this revision.Mar 26 2019, 1:33 PM

I usually try to separate the target specific part when possible: D59840

Fair enough, LGTM.

This revision is now accepted and ready to land.Mar 26 2019, 1:33 PM
arsenm closed this revision.Mar 27 2019, 9:36 AM

r357087