[DWARF] Delete one unused DWARFContext::create overload and associated ctor of DWARFObjInMemory

[MaskRay]

Fix typo in the title

[dblaikie]

Assuming you've checked this is unused in other projects like lldb, lld, etc, sounds good to me - thanks!

[MaskRay]

Oops it is used by unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp but not in library code. Let me see how to update the tests to use the other DWAAARFContext::create.

include/llvm/DebugInfo/DWARF/DWARFContext.h

public:
   /// Function used to handle default error reporting policy. Prints a error
   /// message and returns Continue, so DWARF context ignores the error.
   static ErrorPolicy defaultErrorHandler(Error E);
   static std::unique_ptr<DWARFContext>
   create(const object::ObjectFile &Obj, const LoadedObjectInfo *L = nullptr,
          function_ref<ErrorPolicy(Error)> HandleError = defaultErrorHandler,
          std::string DWPName = "");
 
-  static std::unique_ptr<DWARFContext>
-  create(const StringMap<std::unique_ptr<MemoryBuffer>> &Sections,
-         uint8_t AddrSize, bool isLittleEndian = sys::IsLittleEndianHost);
-
   /// Loads register info for the architecture of the provided object file.
   /// Improves readability of dumped DWARF expressions. Requires the caller to
   /// have initialized the relevant target descriptions.
   Error loadRegisterInfo(const object::ObjectFile &Obj);
 
   /// Get address size from CUs.
   /// TODO: refactor compile_units() to make this const.
   uint8_t getCUAddrSize();

lib/DebugInfo/DWARF/DWARFContext.cpp

Error maybeDecompress(const object::SectionRef &Sec, StringRef Name,
 
     UncompressedSections.push_back(std::move(Out));
     Data = UncompressedSections.back();
 
     return Error::success();
   }
 
 public:
-  DWARFObjInMemory(const StringMap<std::unique_ptr<MemoryBuffer>> &Sections,
-                   uint8_t AddrSize, bool IsLittleEndian)
-      : IsLittleEndian(IsLittleEndian) {
-    for (const auto &SecIt : Sections) {
-      if (StringRef *SectionData = mapSectionToMember(SecIt.first()))
-        *SectionData = SecIt.second->getBuffer();
-      else if (SecIt.first() == "debug_info")
-        // Find debug_info and debug_types data by section rather than name as
-        // there are multiple, comdat grouped, of these sections.
-        InfoSections[SectionRef()].Data = SecIt.second->getBuffer();
-      else if (SecIt.first() == "debug_info.dwo")
-        InfoDWOSections[SectionRef()].Data = SecIt.second->getBuffer();
-      else if (SecIt.first() == "debug_types")
-        TypesSections[SectionRef()].Data = SecIt.second->getBuffer();
-      else if (SecIt.first() == "debug_types.dwo")
-        TypesDWOSections[SectionRef()].Data = SecIt.second->getBuffer();
-    }
-  }
   DWARFObjInMemory(const object::ObjectFile &Obj, const LoadedObjectInfo *L,
                    function_ref<ErrorPolicy(Error)> HandleError)
       : IsLittleEndian(Obj.isLittleEndian()),
         AddressSize(Obj.getBytesInAddress()), FileName(Obj.getFileName()),
         Obj(&Obj) {
 
     StringMap<unsigned> SectionAmountMap;
     for (const SectionRef &Section : Obj.sections()) {

 std::unique_ptr<DWARFContext>
 DWARFContext::create(const object::ObjectFile &Obj, const LoadedObjectInfo *L,
                      function_ref<ErrorPolicy(Error)> HandleError,
                      std::string DWPName) {
   auto DObj = llvm::make_unique<DWARFObjInMemory>(Obj, L, HandleError);
   return llvm::make_unique<DWARFContext>(std::move(DObj), std::move(DWPName));
 }
 
-std::unique_ptr<DWARFContext>
-DWARFContext::create(const StringMap<std::unique_ptr<MemoryBuffer>> &Sections,
-                     uint8_t AddrSize, bool isLittleEndian) {
-  auto DObj =
-      llvm::make_unique<DWARFObjInMemory>(Sections, AddrSize, isLittleEndian);
-  return llvm::make_unique<DWARFContext>(std::move(DObj), "");
-}
-
 Error DWARFContext::loadRegisterInfo(const object::ObjectFile &Obj) {
   // Detect the architecture from the object file. We usually don't need OS
   // info to lookup a target and create register info.
   Triple TT;
   TT.setArch(Triple::ArchType(Obj.getArch()));
   TT.setVendor(Triple::UnknownVendor);
   TT.setOS(Triple::UnknownOS);
   std::string TargetLookupError;