Page MenuHomePhabricator

[DWARF] Delete one unused DWARFContext::create overload and associated ctor of DWARFObjInMemory
AcceptedPublic

Authored by MaskRay on Mar 22 2019, 7:15 PM.

Details

Diff Detail

Event Timeline

MaskRay created this revision.Mar 22 2019, 7:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2019, 7:15 PM
MaskRay updated this revision to Diff 191983.Mar 22 2019, 7:16 PM
MaskRay retitled this revision from [DWARF] Delete one unused DWARFContext::create overload and asscoaited ctor of DWARFObjInMemory to [DWARF] Delete one unused DWARFContext::create overload and associated ctor of DWARFObjInMemory.

Fix typo in the title

dblaikie accepted this revision.Mar 22 2019, 7:20 PM

Assuming you've checked this is unused in other projects like lldb, lld, etc, sounds good to me - thanks!

This revision is now accepted and ready to land.Mar 22 2019, 7:20 PM

Oops it is used by unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp but not in library code. Let me see how to update the tests to use the other DWAAARFContext::create.