Use explicit loop instead of map for Python 2/3 compat

[serge-sans-paille]

Summary

The output of map is not used, so using a list comprehension or an explicit call to list looks awkward.

lldb/trunk/scripts/Xcode/build-llvm.py

 
 def check_out_if_needed(spec):
     if not os.path.isdir(spec['root']):
         vcs(spec).check_out()
         apply_patches(spec)
 
 
 def all_check_out_if_needed():
-    map(check_out_if_needed, XCODE_REPOSITORIES())
+    for r in XCODE_REPOSITORIES():
+        check_out_if_needed(r)
 
 
 def should_build_llvm():
     if build_type() == BuildType.Xcode:
         # TODO use md5 sums
         return True
 
 
 def do_symlink(source_path, link_path):
     print "Symlinking " + source_path + " to " + link_path
     if os.path.islink(link_path):
         os.remove(link_path)
     if not os.path.exists(link_path):
         os.symlink(source_path, link_path)
 
 
 def setup_source_symlink(repo):
     source_path = repo["root"]
     link_path = os.path.join(lldb_source_path(), os.path.basename(source_path))
     do_symlink(source_path, link_path)
 
 
 def setup_source_symlinks():
-    map(setup_source_symlink, XCODE_REPOSITORIES())
+    for r in XCODE_REPOSITORIES():
+        setup_source_symlink(r)
 
 
 def setup_build_symlink():
     # We don't use the build symlinks in llvm.org Xcode-based builds.
     if build_type() != BuildType.Xcode:
         source_path = package_build_path()
         link_path = expected_package_build_path()
         do_symlink(source_path, link_path)