python 2/3 compat: commands vs subprocess

lldb/trunk/examples/python/delta.py

 # To use this in the embedded python interpreter using "lldb" just
 # import it with the full path using the "command script import"
 # command. This can be done from the LLDB command line:
 #   (lldb) command script import /path/to/gdbremote.py
 # Or it can be added to your ~/.lldbinit file so this module is always
 # available.
 #----------------------------------------------------------------------
 
-import commands
 from __future__ import print_function
 
 import optparse
 import os
 import shlex
 import re
 import tempfile
 

lldb/trunk/examples/python/gdbremote.py

 # import it with the full path using the "command script import"
 # command. This can be done from the LLDB command line:
 #   (lldb) command script import /path/to/gdbremote.py
 # Or it can be added to your ~/.lldbinit file so this module is always
 # available.
 #----------------------------------------------------------------------
 
 import binascii
-import commands
+import subprocess
 import json
 import math
 import optparse
 import os
 import re
 import shlex
 import string
 import sys

lldb/trunk/examples/python/globals.py

 #!/usr/bin/python
 
 #----------------------------------------------------------------------
 # For the shells csh, tcsh:
 #   ( setenv PYTHONPATH /Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python ; ./globals.py <path> [<path> ...])
 #
 # For the shells sh, bash:
 #   PYTHONPATH=/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python ./globals.py <path> [<path> ...]
 #----------------------------------------------------------------------
 from __future__ import print_function
 
 import lldb
-import commands
 import optparse
 import os
 import shlex
 import sys
 
 
 def get_globals(raw_path, options):
     error = lldb.SBError()

lldb/trunk/examples/python/memory.py

 #!/usr/bin/python
 
 #----------------------------------------------------------------------
 # Be sure to add the python path that points to the LLDB shared library.
 #
 # # To use this in the embedded python interpreter using "lldb" just
 # import it with the full path using the "command script import"
 # command
 #   (lldb) command script import /path/to/cmdtemplate.py
 #----------------------------------------------------------------------
 
-import commands
 from __future__ import print_function
 
 import platform
 import os
 import re
 import sys
 
+if sys.version_info.major == 2:
+    import commands as subprocess
+else:
+    import subprocess
+
 try:
     # Just try for LLDB in case PYTHONPATH is already correctly setup
     import lldb
 except ImportError:
     lldb_python_dirs = list()
     # lldb is not in the PYTHONPATH, try some defaults for the current platform
     platform_system = platform.system()
     if platform_system == 'Darwin':
         # On Darwin, try the currently selected Xcode directory
-        xcode_dir = commands.getoutput("xcode-select --print-path")
+        xcode_dir = subprocess.getoutput("xcode-select --print-path")
         if xcode_dir:
             lldb_python_dirs.append(
                 os.path.realpath(
                     xcode_dir +
                     '/../SharedFrameworks/LLDB.framework/Resources/Python'))
             lldb_python_dirs.append(
                 xcode_dir + '/Library/PrivateFrameworks/LLDB.framework/Resources/Python')
         lldb_python_dirs.append(
for lldb_python_dir in lldb_python_dirs:
                 else:
                     print('imported lldb from: "%s"' % (lldb_python_dir))
                     success = True
                     break
     if not success:
         print("error: couldn't locate the 'lldb' module, please set PYTHONPATH correctly")
         sys.exit(1)
 
-import commands
 import optparse
 import shlex
 import string
 import struct
 import time
 
 
 def append_data_callback(option, opt_str, value, parser):

lldb/trunk/examples/python/performance.py

 #!/usr/bin/python
 
 #----------------------------------------------------------------------
 # Be sure to add the python path that points to the LLDB shared library.
 # On MacOSX csh, tcsh:
 #   setenv PYTHONPATH /Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python
 # On MacOSX sh, bash:
 #   export PYTHONPATH=/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python
 #----------------------------------------------------------------------
 
-import commands
 from __future__ import print_function
 
 import optparse
 import os
 import platform
 import re
 import resource
 import sys
 import time
 import types
 
+if sys.version_info.major == 2:
+    import commands as subprocess
+else:
+    import subprocess
+
 #----------------------------------------------------------------------
 # Code that auto imports LLDB
 #----------------------------------------------------------------------
 try:
     # Just try for LLDB in case PYTHONPATH is already correctly setup
     import lldb
 except ImportError:
     lldb_python_dirs = list()
     # lldb is not in the PYTHONPATH, try some defaults for the current platform
     platform_system = platform.system()
     if platform_system == 'Darwin':
         # On Darwin, try the currently selected Xcode directory
-        xcode_dir = commands.getoutput("xcode-select --print-path")
+        xcode_dir = subprocess.getoutput("xcode-select --print-path")
         if xcode_dir:
             lldb_python_dirs.append(
                 os.path.realpath(
                     xcode_dir +
                     '/../SharedFrameworks/LLDB.framework/Resources/Python'))
             lldb_python_dirs.append(
                 xcode_dir + '/Library/PrivateFrameworks/LLDB.framework/Resources/Python')
         lldb_python_dirs.append(
def __init__(self, pid):
             "faults",
             "cow",
             "pageins"]
         self.command = "top -l 1 -pid %u -stats %s" % (
             self.pid, ",".join(self.stats))
         self.value = dict()
 
     def Measure(self):
-        output = commands.getoutput(self.command).split("\n")[-1]
+        output = subprocess.getoutput(self.command).split("\n")[-1]
         values = re.split('[-+\s]+', output)
         for (idx, stat) in enumerate(values):
             multiplier = 1
             if stat:
                 if stat[-1] == 'K':
                     multiplier = 1024
                     stat = stat[:-1]
                 elif stat[-1] == 'M':

lldb/trunk/examples/python/process_events.py

 #!/usr/bin/python
 
 #----------------------------------------------------------------------
 # Be sure to add the python path that points to the LLDB shared library.
 # On MacOSX csh, tcsh:
 #   setenv PYTHONPATH /Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python
 # On MacOSX sh, bash:
 #   export PYTHONPATH=/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python
 #----------------------------------------------------------------------
 
-import commands
 from __future__ import print_function
 
 import optparse
 import os
 import platform
 import sys
 
+if sys.version_info.major == 2:
+    import commands as subprocess
+else:
+    import subprocess
+
 #----------------------------------------------------------------------
 # Code that auto imports LLDB
 #----------------------------------------------------------------------
 try:
     # Just try for LLDB in case PYTHONPATH is already correctly setup
     import lldb
 except ImportError:
     lldb_python_dirs = list()
     # lldb is not in the PYTHONPATH, try some defaults for the current platform
     platform_system = platform.system()
     if platform_system == 'Darwin':
         # On Darwin, try the currently selected Xcode directory
-        xcode_dir = commands.getoutput("xcode-select --print-path")
+        xcode_dir = subprocess.getoutput("xcode-select --print-path")
         if xcode_dir:
             lldb_python_dirs.append(
                 os.path.realpath(
                     xcode_dir +
                     '/../SharedFrameworks/LLDB.framework/Resources/Python'))
             lldb_python_dirs.append(
                 xcode_dir + '/Library/PrivateFrameworks/LLDB.framework/Resources/Python')
         lldb_python_dirs.append(

lldb/trunk/examples/python/stacks.py

 #!/usr/bin/python
 from __future__ import print_function
 import lldb
-import commands
 import optparse
 import shlex
 
 
 def stack_frames(debugger, command, result, dict):
     command_args = shlex.split(command)
     usage = "usage: %prog [options] <PATH> [PATH ...]"
     description = '''This command will enumerate all stack frames, print the stack size for each, and print an aggregation of which functions have the largest stack frame sizes at the end.'''

lldb/trunk/examples/python/types.py

 #!/usr/bin/python
 
 #----------------------------------------------------------------------
 # Be sure to add the python path that points to the LLDB shared library.
 #
 # # To use this in the embedded python interpreter using "lldb" just
 # import it with the full path using the "command script import"
 # command
 #   (lldb) command script import /path/to/cmdtemplate.py
 #----------------------------------------------------------------------
 
-import commands
 from __future__ import print_function
 
 import platform
 import os
 import re
 import signal
 import sys
 
+if sys.version_info.major == 2:
+    import commands as subprocess
+else:
+    import subprocess
+
 try:
     # Just try for LLDB in case PYTHONPATH is already correctly setup
     import lldb
 except ImportError:
     lldb_python_dirs = list()
     # lldb is not in the PYTHONPATH, try some defaults for the current platform
     platform_system = platform.system()
     if platform_system == 'Darwin':
         # On Darwin, try the currently selected Xcode directory
-        xcode_dir = commands.getoutput("xcode-select --print-path")
+        xcode_dir = subprocess.getoutput("xcode-select --print-path")
         if xcode_dir:
             lldb_python_dirs.append(
                 os.path.realpath(
                     xcode_dir +
                     '/../SharedFrameworks/LLDB.framework/Resources/Python'))
             lldb_python_dirs.append(
                 xcode_dir + '/Library/PrivateFrameworks/LLDB.framework/Resources/Python')
         lldb_python_dirs.append(
for lldb_python_dir in lldb_python_dirs:
                 else:
                     print('imported lldb from: "%s"' % (lldb_python_dir))
                     success = True
                     break
     if not success:
         print("error: couldn't locate the 'lldb' module, please set PYTHONPATH correctly")
         sys.exit(1)
 
-import commands
 import optparse
 import shlex
 import time
 
 
 def regex_option_callback(option, opt_str, value, parser):
     if opt_str == "--std":
         value = '^std::'

lldb/trunk/scripts/verify_api.py

 #!/usr/bin/env python
 
-import commands
+import subprocess
 import optparse
 import os
 import os.path
 import re
 import sys
 
 
 def extract_exe_symbol_names(arch, exe_path, match_str):
     command = 'dsymutil --arch %s -s "%s" | grep "%s" | colrm 1 69' % (
         arch, exe_path, match_str)
-    (command_exit_status, command_output) = commands.getstatusoutput(command)
+    (command_exit_status, command_output) = subprocess.getstatusoutput(command)
     if command_exit_status == 0:
         if command_output:
             return command_output[0:-1].split("'\n")
         else:
             print('error: command returned no output')
     else:
         print('error: command failed with exit status %i\n    command: %s' % (command_exit_status, command))
     return list()