This is an archive of the discontinued LLVM Phabricator instance.

gn build: Add build files for some clang-tools-extra
ClosedPublic

Authored by thakis on Mar 19 2019, 11:31 AM.

Diff Detail

Event Timeline

thakis created this revision.Mar 19 2019, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2019, 11:31 AM
Herald added subscribers: ioeric, mgorny. · View Herald Transcript
mbonadei added inline comments.Mar 19 2019, 10:37 PM
llvm/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn
12
thakis updated this revision to Diff 191486.Mar 20 2019, 7:13 AM
thakis marked an inline comment as done.

comments

Thanks!

llvm/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn
12

Good catch, done.

In practice it doesn't matter because the tool/ has the dep, but all targets currently try to match the cmake deps (which has them for component builds I think), so I agree this should be here :)

mbonadei accepted this revision.Mar 20 2019, 8:18 AM

LGTM!

This revision is now accepted and ready to land.Mar 20 2019, 8:18 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2019, 9:16 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript