This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Mark internal types of std::filesystem as hidden
ClosedPublic

Authored by ldionne on Mar 19 2019, 9:12 AM.

Details

Summary

Otherwise, implicit instantiations of templates with these types can
cause the dylib to start exporting the vtable/RTTI of the instantiation.
Giving hidden visibility to those types causes the compiler to understand
that they are not used outside the dylib, and as a result implicitly
instantiated vtables/RTTI of templates with those internal types will
get hidden visibility.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Mar 19 2019, 9:12 AM
EricWF accepted this revision.Mar 19 2019, 10:07 AM
This revision is now accepted and ready to land.Mar 19 2019, 10:07 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2019, 10:47 AM