Page MenuHomePhabricator

[libc++][CMake] Clean up some of the libc++ re-exporting logic
ClosedPublic

Authored by ldionne on Mar 18 2019, 7:33 AM.

Details

Summary

This change allows specifying the version of libc++abi's ABI to re-export
when configuring CMake. It also clearly identifies which ABI version of
libc++abi each export file contains.

Finally, it removes hardcoded knowledge about the 10.9 SDK for MacOS,
since that knowledge is not relevant anymore. Indeed, libc++ can't be
built with the toolchain that came with the 10.9 SDK anyway because
the version of Clang it includes is too old (for example if you want
to build a working libc++.dylib, you need bugfixes to visibility
attributes that are only in recent Clangs).

Diff Detail

Repository
rCXX libc++

Event Timeline

ldionne created this revision.Mar 18 2019, 7:33 AM
This revision is now accepted and ready to land.Mar 20 2019, 10:40 AM
This revision was automatically updated to reflect the committed changes.