This is an archive of the discontinued LLVM Phabricator instance.

Differential D59432

[CMake] Correct CMake message mode
ClosedPublic

Authored by xiaobai on Mar 15 2019, 1:19 PM.

Details

Reviewers
zturner
smeenai
Commits
rG5ac90b8ba1b3: [CMake] Correct CMake message mode
rL356297: [CMake] Correct CMake message mode
Summary

This wasn't actually printing out a CMake warning, it was prepending
"WARN" to the message.

Diff Detail

Event Timeline

xiaobai created this revision.Mar 15 2019, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2019, 1:19 PM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B29226: Diff 190889.Mar 15 2019, 1:21 PM
smeenai accepted this revision.Mar 15 2019, 1:26 PM
smeenai added a subscriber: smeenai.

I think this is small and obvious enough that you could just commit directly for post-commit review :)

This revision is now accepted and ready to land.Mar 15 2019, 1:26 PM
Closed by commit rL356297: [CMake] Correct CMake message mode (authored by xiaobai). · Explain WhyMar 15 2019, 1:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
modules/
2 lines

Diff 190889

cmake/modules/AddLLVM.cmake

Show First 20 Lines • Show All 1,305 Lines • ▼ Show 20 Lines if (ARG_ALLOW_EXTERNAL)
if (NOT "${LLVM_EXTERNAL_LIT}" STREQUAL "") if (NOT "${LLVM_EXTERNAL_LIT}" STREQUAL "")
if (EXISTS ${LLVM_EXTERNAL_LIT}) if (EXISTS ${LLVM_EXTERNAL_LIT})
get_filename_component(LIT_FILE_NAME ${LLVM_EXTERNAL_LIT} NAME) get_filename_component(LIT_FILE_NAME ${LLVM_EXTERNAL_LIT} NAME)
get_filename_component(LIT_BASE_DIR ${LLVM_EXTERNAL_LIT} DIRECTORY) get_filename_component(LIT_BASE_DIR ${LLVM_EXTERNAL_LIT} DIRECTORY)
set(${file_name} ${LIT_FILE_NAME} PARENT_SCOPE) set(${file_name} ${LIT_FILE_NAME} PARENT_SCOPE)
set(${base_dir} ${LIT_BASE_DIR} PARENT_SCOPE) set(${base_dir} ${LIT_BASE_DIR} PARENT_SCOPE)
return() return()
else() else()
message(WARN "LLVM_EXTERNAL_LIT set to ${LLVM_EXTERNAL_LIT}, but the path does not exist.") message(WARNING "LLVM_EXTERNAL_LIT set to ${LLVM_EXTERNAL_LIT}, but the path does not exist.")
endif() endif()
endif() endif()
endif() endif()
set(lit_file_name "llvm-lit") set(lit_file_name "llvm-lit")
if (CMAKE_HOST_WIN32 AND NOT CYGWIN) if (CMAKE_HOST_WIN32 AND NOT CYGWIN)
# llvm-lit needs suffix.py for multiprocess to find a main module. # llvm-lit needs suffix.py for multiprocess to find a main module.
set(lit_file_name "${lit_file_name}.py") set(lit_file_name "${lit_file_name}.py")
▲ Show 20 Lines • Show All 440 Lines • Show Last 20 Lines