Page MenuHomePhabricator

[LLD][COFF] Separate module descriptors creation from type/symbol merging
ClosedPublic

Authored by aganea on Mar 12 2019, 9:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

aganea created this revision.Mar 12 2019, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 9:12 AM
aganea updated this revision to Diff 190295.Mar 12 2019, 10:55 AM
aganea edited the summary of this revision. (Show Details)

Simplify.

rnk accepted this revision.Mar 14 2019, 1:00 PM

lgtm

COFF/InputFiles.h
162 ↗(On Diff #190295)

I would suggest MergedIntoPDB or something more descriptive. This is only used in one place, so it doesn't need to be short. "Merged" could mean a lot of things, and someone using DWARF might assume this was relating to PDBs.

This revision is now accepted and ready to land.Mar 14 2019, 1:00 PM
This revision was automatically updated to reflect the committed changes.
aganea marked an inline comment as done.