test/CMakeLists.txt
3	I don't understand why we're changing this file. The previous one works just as well, but it does not require adding `CMakeLists.txt`s all over the place in the tree (which just won't scale to the number of tests that will be in the suite). The next improvement over this should be to run the tests with `lit` (but should be tackled separately).

This revision now requires changes to proceed.Mar 12 2019, 7:56 AM

To be clear about what I'd like: please do not add CMakeLists.txts all over the tree, instead keep relying on GLOB_RECURSE like my current test/CMakeLists.txt does.

In D59110#1426159, @ldionne wrote:

To be clear about what I'd like: please do not add CMakeLists.txts all over the tree, instead keep relying on GLOB_RECURSE like my current test/CMakeLists.txt does.

Sure, I can make that change. The CMakeLists.txt's were generated by a migration script I wrote to restructure the original test suite. I expected to nuke all of that anyway once lit was tackled.

Remove nested CMakeLists.txt in test/std, replace with glob-recurse

Harbormaster completed remote builds in B29320: Diff 191214.Mar 18 2019, 5:13 PM

ldionne requested changes to this revision.Mar 20 2019, 12:32 PM

ldionne added inline comments.

test/CMakeLists.txt
14–15	Please use `target_include_directories("pstl-${target}" PRIVATE "${CMAKE_CURRENT_LIST_DIR}")` below instead. `"${PROJECT_SOURCE_DIR}/include"` shouldn't be necessary at all since the tests link against `pstl::ParallelSTL`, which has `"${PROJECT_SOURCE_DIR}/include"` as an `INTERFACE` include directory.
17	Please use `target_compile_definitions("pstl-${target}" PRIVATE -DPSTL_STANDALONE_TESTS)` below instead. Setting global flags is frowned upon in modern CMake.

This revision now requires changes to proceed.Mar 20 2019, 12:32 PM

Applied by "other means"

Large Diff

This large diff affects 130 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

CMakeLists.txt

4 lines

test/

CMakeLists.txt

40 lines

pstl_test_config.h

std/

CMakeLists.txt

3 lines

algorithms/

CMakeLists.txt

4 lines

alg.merge/

CMakeLists.txt

9 lines

alg.modifying.operations/

CMakeLists.txt

25 lines

alg.copy/

CMakeLists.txt

8 lines

alg.partitions/

CMakeLists.txt

10 lines

alg.reverse/

CMakeLists.txt

9 lines

alg.nonmodifying/

CMakeLists.txt

21 lines

alg.sorting/

CMakeLists.txt

16 lines

alg.heap.operations/

CMakeLists.txt

8 lines

alg.lex.comparison/

CMakeLists.txt

8 lines

alg.min.max/

CMakeLists.txt

8 lines

alg.set.operations/

CMakeLists.txt

9 lines

numerics/

CMakeLists.txt

1 line

numeric.ops/

CMakeLists.txt

12 lines

utilities/

CMakeLists.txt

1 line

memory/

CMakeLists.txt

1 line

specialized.algorithms/

CMakeLists.txt

10 lines

	std/

	algorithms/

	alg.merge/

	inplace_merge.pass.cpp
	test_inplace_merge.cpp

12 lines

	merge.pass.cpp
	test_merge.cpp

12 lines

	alg.modifying.operations/

	alg.copy/

	copy_if.pass.cpp
	test_copy_if.cpp

12 lines

	alg.partitions/

	is_partitioned.pass.cpp
	test_is_partitioned.cpp

12 lines

	partition.pass.cpp
	test_partition.cpp

12 lines

	partition_copy.pass.cpp
	test_partition_copy.cpp

12 lines

	alg.reverse/

	reverse.pass.cpp
	test_reverse.cpp

12 lines

	reverse_copy.pass.cpp
	test_reverse_copy.cpp

12 lines

	copy_move.pass.cpp
	test_copy_move.cpp

12 lines

	fill.pass.cpp
	test_fill.cpp

13 lines

	generate.pass.cpp
	test_generate.cpp

13 lines

	remove.pass.cpp
	test_remove.cpp

12 lines

	remove_copy.pass.cpp
	test_remove_copy.cpp

13 lines

	replace.pass.cpp
	test_replace.cpp

12 lines

	replace_copy.pass.cpp
	test_replace_copy.cpp

12 lines

	rotate.pass.cpp
	test_rotate.cpp

12 lines

	rotate_copy.pass.cpp
	test_rotate_copy.cpp

12 lines

	swap_ranges.pass.cpp
	test_swap_ranges.cpp

12 lines

	transform_binary.pass.cpp
	test_transform_binary.cpp

14 lines

	transform_unary.pass.cpp
	test_transform_unary.cpp

14 lines

	unique.pass.cpp
	test_unique.cpp

12 lines

	unique_copy_equal.pass.cpp
	test_unique_copy_equal.cpp

12 lines

	alg.nonmodifying/

	adjacent_find.pass.cpp
	test_adjacent_find.cpp

13 lines

	all_of.pass.cpp
	test_all_of.cpp

12 lines

	any_of.pass.cpp
	test_any_of.cpp

12 lines

	count.pass.cpp
	test_count.cpp

12 lines

	equal.pass.cpp
	test_equal.cpp

12 lines

	find.pass.cpp
	test_find.cpp

12 lines

	find_end.pass.cpp
	test_find_end.cpp

12 lines

	find_first_of.pass.cpp
	test_find_first_of.cpp

12 lines

	find_if.pass.cpp
	test_find_if.cpp

12 lines

	for_each.pass.cpp
	test_for_each.cpp

12 lines

	mismatch.pass.cpp
	test_mismatch.cpp

13 lines

	none_of.pass.cpp
	test_none_of.cpp

12 lines

	nth_element.pass.cpp
	test_nth_element.cpp

12 lines

	search_n.pass.cpp
	test_search_n.cpp

12 lines

	alg.sorting/

	alg.heap.operations/

	is_heap.pass.cpp
	test_is_heap.cpp

12 lines

	alg.lex.comparison/

	lexicographical_compare.pass.cpp
	test_lexicographical_compare.cpp

14 lines

	alg.min.max/

	minmax_element.pass.cpp
	test_minmax_element.cpp

13 lines

	alg.set.operations/

	includes.pass.cpp
	test_includes.cpp

13 lines

	set.pass.cpp
	test_set.cpp

13 lines

	is_sorted.pass.cpp
	test_is_sorted.cpp

13 lines

	partial_sort.pass.cpp
	test_partial_sort.cpp

13 lines

	partial_sort_copy.pass.cpp
	test_partial_sort_copy.cpp

12 lines

	sort.pass.cpp
	test_sort.cpp

13 lines

	numerics/	numeric.ops/

	adjacent_difference.pass.cpp
	test_adjacent_difference.cpp

12 lines

	reduce.pass.cpp
	test_reduce.cpp

12 lines

	scan.pass.cpp
	test_scan.cpp

13 lines

	transform_reduce.pass.cpp
	test_transform_reduce.cpp

13 lines

	transform_scan.pass.cpp
	test_transform_scan.cpp

13 lines

	utilities/	memory/	specialized.algorithms/

	uninitialized_construct.pass.cpp
	test_uninitialized_construct.cpp

12 lines

	uninitialized_copy_move.pass.cpp
	test_uninitialized_copy_move.cpp

12 lines

	uninitialized_fill_destroy.pass.cpp
	test_uninitialized_fill_destroy.cpp

13 lines

	support/

pstl_test_config.h

49 lines

utils.h

1248 lines

test_adjacent_difference.cpp

test_adjacent_find.cpp

test_find_first_of.cpp

test_inplace_merge.cpp

test_is_heap.cpp

test_is_partitioned.cpp

test_is_sorted.cpp

test_lexicographical_compare.cpp

test_merge.cpp

test_minmax_element.cpp

test_mismatch.cpp

test_none_of.cpp

test_nth_element.cpp

test_partial_sort.cpp

test_partial_sort_copy.cpp

test_partition.cpp

test_partition_copy.cpp

test_replace_copy.cpp

test_reverse.cpp

test_reverse_copy.cpp

test_transform_binary.cpp

test_transform_reduce.cpp

test_transform_scan.cpp

test_transform_unary.cpp

test_uninitialized_construct.cpp

test_uninitialized_copy_move.cpp

test_uninitialized_fill_destroy.cpp

Restructure existing test suite to follow libc++ standard layoutAbandonedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 189784

CMakeLists.txt

test/CMakeLists.txt

test/pstl_test_config.h

test/std/CMakeLists.txt

test/std/algorithms/CMakeLists.txt

test/std/algorithms/alg.merge/CMakeLists.txt

test/std/algorithms/alg.merge/inplace_merge.pass.cpp

test/std/algorithms/alg.merge/merge.pass.cpp

test/std/algorithms/alg.modifying.operations/CMakeLists.txt

test/std/algorithms/alg.modifying.operations/alg.copy/CMakeLists.txt

test/std/algorithms/alg.modifying.operations/alg.copy/copy_if.pass.cpp

test/std/algorithms/alg.modifying.operations/alg.partitions/CMakeLists.txt

test/std/algorithms/alg.modifying.operations/alg.partitions/is_partitioned.pass.cpp

test/std/algorithms/alg.modifying.operations/alg.partitions/partition.pass.cpp

test/std/algorithms/alg.modifying.operations/alg.partitions/partition_copy.pass.cpp

test/std/algorithms/alg.modifying.operations/alg.reverse/CMakeLists.txt

test/std/algorithms/alg.modifying.operations/alg.reverse/reverse.pass.cpp

test/std/algorithms/alg.modifying.operations/alg.reverse/reverse_copy.pass.cpp

test/std/algorithms/alg.modifying.operations/copy_move.pass.cpp

test/std/algorithms/alg.modifying.operations/fill.pass.cpp

test/std/algorithms/alg.modifying.operations/generate.pass.cpp

test/std/algorithms/alg.modifying.operations/remove.pass.cpp

test/std/algorithms/alg.modifying.operations/remove_copy.pass.cpp

test/std/algorithms/alg.modifying.operations/replace.pass.cpp

test/std/algorithms/alg.modifying.operations/replace_copy.pass.cpp

test/std/algorithms/alg.modifying.operations/rotate.pass.cpp

test/std/algorithms/alg.modifying.operations/rotate_copy.pass.cpp

test/std/algorithms/alg.modifying.operations/swap_ranges.pass.cpp

test/std/algorithms/alg.modifying.operations/transform_binary.pass.cpp

test/std/algorithms/alg.modifying.operations/transform_unary.pass.cpp

test/std/algorithms/alg.modifying.operations/unique.pass.cpp

test/std/algorithms/alg.modifying.operations/unique_copy_equal.pass.cpp

test/std/algorithms/alg.nonmodifying/CMakeLists.txt

test/std/algorithms/alg.nonmodifying/adjacent_find.pass.cpp

test/std/algorithms/alg.nonmodifying/all_of.pass.cpp

test/std/algorithms/alg.nonmodifying/any_of.pass.cpp

test/std/algorithms/alg.nonmodifying/count.pass.cpp

test/std/algorithms/alg.nonmodifying/equal.pass.cpp

test/std/algorithms/alg.nonmodifying/find.pass.cpp

test/std/algorithms/alg.nonmodifying/find_end.pass.cpp

test/std/algorithms/alg.nonmodifying/find_first_of.pass.cpp

test/std/algorithms/alg.nonmodifying/find_if.pass.cpp

test/std/algorithms/alg.nonmodifying/for_each.pass.cpp

test/std/algorithms/alg.nonmodifying/mismatch.pass.cpp

test/std/algorithms/alg.nonmodifying/none_of.pass.cpp

test/std/algorithms/alg.nonmodifying/nth_element.pass.cpp

test/std/algorithms/alg.nonmodifying/search_n.pass.cpp

test/std/algorithms/alg.sorting/CMakeLists.txt

test/std/algorithms/alg.sorting/alg.heap.operations/CMakeLists.txt

test/std/algorithms/alg.sorting/alg.heap.operations/is_heap.pass.cpp

test/std/algorithms/alg.sorting/alg.lex.comparison/CMakeLists.txt

test/std/algorithms/alg.sorting/alg.lex.comparison/lexicographical_compare.pass.cpp

test/std/algorithms/alg.sorting/alg.min.max/CMakeLists.txt

test/std/algorithms/alg.sorting/alg.min.max/minmax_element.pass.cpp

test/std/algorithms/alg.sorting/alg.set.operations/CMakeLists.txt

test/std/algorithms/alg.sorting/alg.set.operations/includes.pass.cpp

test/std/algorithms/alg.sorting/alg.set.operations/set.pass.cpp

test/std/algorithms/alg.sorting/is_sorted.pass.cpp

test/std/algorithms/alg.sorting/partial_sort.pass.cpp

test/std/algorithms/alg.sorting/partial_sort_copy.pass.cpp

test/std/algorithms/alg.sorting/sort.pass.cpp

test/std/numerics/CMakeLists.txt

test/std/numerics/numeric.ops/CMakeLists.txt

test/std/numerics/numeric.ops/adjacent_difference.pass.cpp

test/std/numerics/numeric.ops/reduce.pass.cpp

test/std/numerics/numeric.ops/scan.pass.cpp

test/std/numerics/numeric.ops/transform_reduce.pass.cpp

test/std/numerics/numeric.ops/transform_scan.pass.cpp

test/std/utilities/CMakeLists.txt

test/std/utilities/memory/CMakeLists.txt

test/std/utilities/memory/specialized.algorithms/CMakeLists.txt

test/std/utilities/memory/specialized.algorithms/uninitialized_construct.pass.cpp

test/std/utilities/memory/specialized.algorithms/uninitialized_copy_move.pass.cpp

Restructure existing test suite to follow libc++ standard layout
AbandonedPublic
Actions

Revision Contents
Changeset List