This is an archive of the discontinued LLVM Phabricator instance.

Differential D59089

[llvm-readobj] Dump DT_USED value as string like GNU readelf does
ClosedPublic

Authored by Higuoxing on Mar 7 2019, 3:53 AM.

Details

Reviewers
jhenderson
Commits
rGeee6226c21d7: [llvm-readobj] Dump DT_USED value as string like GNU readelf does
rL355600: [llvm-readobj] Dump DT_USED value as string like GNU readelf does

Diff Detail

Event Timeline

Higuoxing created this revision.Mar 7 2019, 3:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2019, 3:53 AM
Herald added subscribers: llvm-commits, rupprecht. · View Herald Transcript
Harbormaster completed remote builds in B28885: Diff 189689.Mar 7 2019, 3:53 AM
jhenderson added inline comments.Mar 7 2019, 4:37 AM
test/tools/llvm-readobj/elf-dynamic-tags.test
266–267

Could you put this above DT_FILTER, please, since it is before it in the enum range.

tools/llvm-readobj/ELFDumper.cpp
1885–1887

Put this before DT_FILTER, similar to my above comment.

To confirm, GNU readelf prints it as "Not needed object"?

Higuoxing updated this revision to Diff 189692.Mar 7 2019, 4:53 AM

Addressed @jhenderson 's comments

  • Put DT_USED before DT_FILTER. (Sorry, I should have noticed this)
  • Yes, my GNU readelf prints Not needed object: [U]
Harbormaster completed remote builds in B28886: Diff 189692.Mar 7 2019, 4:54 AM
jhenderson accepted this revision.Mar 7 2019, 5:33 AM

LGTM.

This revision is now accepted and ready to land.Mar 7 2019, 5:33 AM
Closed by commit rL355600: [llvm-readobj] Dump DT_USED value as string like GNU readelf does (authored by Higuoxing). · Explain WhyMar 7 2019, 6:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tools/
llvm-readobj/
8 lines
tools/
llvm-readobj/
3 lines

Diff 189692

test/tools/llvm-readobj/elf-dynamic-tags.test

# Show that all non-machine specific tags can be read and printed correctly. # Show that all non-machine specific tags can be read and printed correctly.
# RUN: yaml2obj %s > %t # RUN: yaml2obj %s > %t
# RUN: llvm-readobj --dynamic-table %t | FileCheck %s --check-prefix=LLVM # RUN: llvm-readobj --dynamic-table %t | FileCheck %s --check-prefix=LLVM
# RUN: llvm-readelf --dynamic-table %t | FileCheck %s --check-prefix=GNU # RUN: llvm-readelf --dynamic-table %t | FileCheck %s --check-prefix=GNU
# LLVM: DynamicSection [ (60 entries) # LLVM: DynamicSection [ (61 entries)
# LLVM-NEXT: Tag Type Name/Value # LLVM-NEXT: Tag Type Name/Value
# LLVM-NEXT: 0x0000000000000001 NEEDED Shared library: [D] # LLVM-NEXT: 0x0000000000000001 NEEDED Shared library: [D]
# LLVM-NEXT: 0x0000000000000002 PLTRELSZ 16 (bytes) # LLVM-NEXT: 0x0000000000000002 PLTRELSZ 16 (bytes)
# LLVM-NEXT: 0x0000000000000003 PLTGOT 0x1000 # LLVM-NEXT: 0x0000000000000003 PLTGOT 0x1000
# LLVM-NEXT: 0x0000000000000004 HASH 0x1000 # LLVM-NEXT: 0x0000000000000004 HASH 0x1000
# LLVM-NEXT: 0x0000000000000005 STRTAB 0x1000 # LLVM-NEXT: 0x0000000000000005 STRTAB 0x1000
# LLVM-NEXT: 0x0000000000000006 SYMTAB 0x1000 # LLVM-NEXT: 0x0000000000000006 SYMTAB 0x1000
# LLVM-NEXT: 0x0000000000000007 RELA 0x1000 # LLVM-NEXT: 0x0000000000000007 RELA 0x1000
Show All 40 Lines
# LLVM-NEXT: 0x000000006FFFFFFA RELCOUNT 0 # LLVM-NEXT: 0x000000006FFFFFFA RELCOUNT 0
# LLVM-NEXT: 0x000000006FFFFFFB FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}} # LLVM-NEXT: 0x000000006FFFFFFB FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}}
# LLVM-NEXT: 0x000000006FFFFFF0 VERSYM 0x1000 # LLVM-NEXT: 0x000000006FFFFFF0 VERSYM 0x1000
# LLVM-NEXT: 0x000000006FFFFFFC VERDEF 0x1000 # LLVM-NEXT: 0x000000006FFFFFFC VERDEF 0x1000
# LLVM-NEXT: 0x000000006FFFFFFD VERDEFNUM 0 # LLVM-NEXT: 0x000000006FFFFFFD VERDEFNUM 0
# LLVM-NEXT: 0x000000006FFFFFFE VERNEED 0x1000 # LLVM-NEXT: 0x000000006FFFFFFE VERNEED 0x1000
# LLVM-NEXT: 0x000000006FFFFFFF VERNEEDNUM 0 # LLVM-NEXT: 0x000000006FFFFFFF VERNEEDNUM 0
# LLVM-NEXT: 0x000000007FFFFFFD AUXILIARY Auxiliary library: [D] # LLVM-NEXT: 0x000000007FFFFFFD AUXILIARY Auxiliary library: [D]
# LLVM-NEXT: 0x000000007FFFFFFE USED Not needed object: [U]
# LLVM-NEXT: 0x000000007FFFFFFF FILTER Filter library: [U] # LLVM-NEXT: 0x000000007FFFFFFF FILTER Filter library: [U]
# LLVM-NEXT: 0x0000000012345678 unknown 0x8765432187654321 # LLVM-NEXT: 0x0000000012345678 unknown 0x8765432187654321
# LLVM-NEXT: 0x000000006ABCDEF0 unknown 0x9988776655443322 # LLVM-NEXT: 0x000000006ABCDEF0 unknown 0x9988776655443322
# LLVM-NEXT: 0x0000000076543210 unknown 0x5555666677778888 # LLVM-NEXT: 0x0000000076543210 unknown 0x5555666677778888
# LLVM-NEXT: 0x0000000000000000 NULL 0x0 # LLVM-NEXT: 0x0000000000000000 NULL 0x0
# LLVM-NEXT: ] # LLVM-NEXT: ]
# GNU: DynamicSection [ (60 entries) # GNU: DynamicSection [ (61 entries)
# GNU-NEXT: Tag Type Name/Value # GNU-NEXT: Tag Type Name/Value
# GNU-NEXT: 0x0000000000000001 NEEDED Shared library: [D] # GNU-NEXT: 0x0000000000000001 NEEDED Shared library: [D]
# GNU-NEXT: 0x0000000000000002 PLTRELSZ 16 (bytes) # GNU-NEXT: 0x0000000000000002 PLTRELSZ 16 (bytes)
# GNU-NEXT: 0x0000000000000003 PLTGOT 0x1000 # GNU-NEXT: 0x0000000000000003 PLTGOT 0x1000
# GNU-NEXT: 0x0000000000000004 HASH 0x1000 # GNU-NEXT: 0x0000000000000004 HASH 0x1000
# GNU-NEXT: 0x0000000000000005 STRTAB 0x1000 # GNU-NEXT: 0x0000000000000005 STRTAB 0x1000
# GNU-NEXT: 0x0000000000000006 SYMTAB 0x1000 # GNU-NEXT: 0x0000000000000006 SYMTAB 0x1000
# GNU-NEXT: 0x0000000000000007 RELA 0x1000 # GNU-NEXT: 0x0000000000000007 RELA 0x1000
Show All 40 Lines
# GNU-NEXT: 0x000000006ffffffa RELCOUNT 0 # GNU-NEXT: 0x000000006ffffffa RELCOUNT 0
# GNU-NEXT: 0x000000006ffffffb FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}} # GNU-NEXT: 0x000000006ffffffb FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}}
# GNU-NEXT: 0x000000006ffffff0 VERSYM 0x1000 # GNU-NEXT: 0x000000006ffffff0 VERSYM 0x1000
# GNU-NEXT: 0x000000006ffffffc VERDEF 0x1000 # GNU-NEXT: 0x000000006ffffffc VERDEF 0x1000
# GNU-NEXT: 0x000000006ffffffd VERDEFNUM 0 # GNU-NEXT: 0x000000006ffffffd VERDEFNUM 0
# GNU-NEXT: 0x000000006ffffffe VERNEED 0x1000 # GNU-NEXT: 0x000000006ffffffe VERNEED 0x1000
# GNU-NEXT: 0x000000006fffffff VERNEEDNUM 0 # GNU-NEXT: 0x000000006fffffff VERNEEDNUM 0
# GNU-NEXT: 0x000000007ffffffd AUXILIARY Auxiliary library: [D] # GNU-NEXT: 0x000000007ffffffd AUXILIARY Auxiliary library: [D]
# GNU-NEXT: 0x000000007ffffffe USED Not needed object: [U]
# GNU-NEXT: 0x000000007fffffff FILTER Filter library: [U] # GNU-NEXT: 0x000000007fffffff FILTER Filter library: [U]
# GNU-NEXT: 0x0000000012345678 unknown 0x8765432187654321 # GNU-NEXT: 0x0000000012345678 unknown 0x8765432187654321
# GNU-NEXT: 0x000000006abcdef0 unknown 0x9988776655443322 # GNU-NEXT: 0x000000006abcdef0 unknown 0x9988776655443322
# GNU-NEXT: 0x0000000076543210 unknown 0x5555666677778888 # GNU-NEXT: 0x0000000076543210 unknown 0x5555666677778888
# GNU-NEXT: 0x0000000000000000 NULL 0x0 # GNU-NEXT: 0x0000000000000000 NULL 0x0
# GNU-NEXT: ] # GNU-NEXT: ]
--- !ELF --- !ELF
▲ Show 20 Lines • Show All 117 Lines • ▼ Show 20 Lines Entries:
- Tag: DT_VERDEFNUM - Tag: DT_VERDEFNUM
Value: 0x0 Value: 0x0
- Tag: DT_VERNEED - Tag: DT_VERNEED
Value: 0x1000 Value: 0x1000
- Tag: DT_VERNEEDNUM - Tag: DT_VERNEEDNUM
Value: 0x0 Value: 0x0
- Tag: DT_AUXILIARY - Tag: DT_AUXILIARY
Value: 0x1 Value: 0x1
- Tag: DT_USED
Value: 0x3
- Tag: DT_FILTER - Tag: DT_FILTER
Value: 0x3 Value: 0x3
# Show behaviour for unknown values in special and un-marked ranges. # Show behaviour for unknown values in special and un-marked ranges.
- Tag: 0x12345678 - Tag: 0x12345678
jhendersonUnsubmitted
Not Done
ReplyInline Actions

Could you put this above DT_FILTER, please, since it is before it in the enum range.

jhenderson: Could you put this above DT_FILTER, please, since it is before it in the enum range.
Value: 0x8765432187654321 Value: 0x8765432187654321
- Tag: 0x6abcdef0 - Tag: 0x6abcdef0
Value: 0x9988776655443322 Value: 0x9988776655443322
- Tag: 0x76543210 - Tag: 0x76543210
Value: 0x5555666677778888 Value: 0x5555666677778888
- Tag: DT_NULL - Tag: DT_NULL
Value: 0x0 Value: 0x0
ProgramHeaders: ProgramHeaders:
Show All 9 Lines

tools/llvm-readobj/ELFDumper.cpp

Show First 20 Lines • Show All 1,870 Lines • ▼ Show 20 Lines case DT_NEEDED:
printLibrary(OS, "Shared library", getDynamicString(Value)); printLibrary(OS, "Shared library", getDynamicString(Value));
break; break;
case DT_SONAME: case DT_SONAME:
printLibrary(OS, "Library soname", getDynamicString(Value)); printLibrary(OS, "Library soname", getDynamicString(Value));
break; break;
case DT_AUXILIARY: case DT_AUXILIARY:
printLibrary(OS, "Auxiliary library", getDynamicString(Value)); printLibrary(OS, "Auxiliary library", getDynamicString(Value));
break; break;
case DT_USED:
printLibrary(OS, "Not needed object", getDynamicString(Value));
break;
case DT_FILTER: case DT_FILTER:
printLibrary(OS, "Filter library", getDynamicString(Value)); printLibrary(OS, "Filter library", getDynamicString(Value));
break; break;
case DT_RPATH: case DT_RPATH:
case DT_RUNPATH: case DT_RUNPATH:
OS << getDynamicString(Value); OS << getDynamicString(Value);
jhendersonUnsubmitted
Not Done
ReplyInline Actions

Put this before DT_FILTER, similar to my above comment.

To confirm, GNU readelf prints it as "Not needed object"?

jhenderson: Put this before DT_FILTER, similar to my above comment. To confirm, GNU readelf prints it as…
break; break;
case DT_MIPS_FLAGS: case DT_MIPS_FLAGS:
printFlags(Value, makeArrayRef(ElfDynamicDTMipsFlags), OS); printFlags(Value, makeArrayRef(ElfDynamicDTMipsFlags), OS);
break; break;
case DT_FLAGS: case DT_FLAGS:
printFlags(Value, makeArrayRef(ElfDynamicDTFlags), OS); printFlags(Value, makeArrayRef(ElfDynamicDTFlags), OS);
break; break;
case DT_FLAGS_1: case DT_FLAGS_1:
▲ Show 20 Lines • Show All 2,937 Lines • Show Last 20 Lines