This is an archive of the discontinued LLVM Phabricator instance.

[LLD][ELF] - Replace one of the tests with a YAML version.
ClosedPublic

Authored by grimar on Mar 7 2019, 2:56 AM.

Diff Detail

Event Timeline

grimar created this revision.Mar 7 2019, 2:56 AM
grimar updated this revision to Diff 189678.Mar 7 2019, 3:00 AM
  • Added missing "# REQUIRES: x86"

Could you look, Rui? This one is trivial, and I posted this because of D59082, which was accepted.

ruiu added inline comments.Mar 11 2019, 8:50 AM
test/ELF/invalid/data-encoding.test
8

Please add the ".o" extension to an object file.

13

It is not clear to me why you had to create an object file in addition to an archive file. Can't you just pass an archive file only?

grimar marked an inline comment as done.Mar 11 2019, 9:04 AM
grimar added inline comments.
test/ELF/invalid/data-encoding.test
13

I do not remember right now, sorry. I'll recheck tomorrow.

MaskRay added inline comments.Mar 11 2019, 11:36 PM
test/ELF/invalid/data-encoding.test
13

If the object file is not passed => ld.lld: error: target emulation unknown: -m or at least one .o file required. --whole-archive can be used.

grimar updated this revision to Diff 190224.Mar 12 2019, 2:23 AM
grimar marked an inline comment as done.
  • Addressed review comments.
test/ELF/invalid/data-encoding.test
13

Right. I used --whole-archive, thanks!

ruiu accepted this revision.Mar 13 2019, 3:42 PM

LGTM

This revision is now accepted and ready to land.Mar 13 2019, 3:42 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2019, 8:44 AM