This is an archive of the discontinued LLVM Phabricator instance.

Differential D59085

[LLD][ELF] - Replace one of the tests with a YAML version.
ClosedPublic

Authored by grimar on Mar 7 2019, 2:56 AM.

Details

Reviewers
ruiu
• espindola
Commits
rG738146ab333e: [LLD][ELF] - Replace one of the tests with a YAML version.
rL356334: [LLD][ELF] - Replace one of the tests with a YAML version.
rLLD356334: [LLD][ELF] - Replace one of the tests with a YAML version.
Summary

This removes one more binary from the inputs.

Diff Detail

Event Timeline

grimar created this revision.Mar 7 2019, 2:56 AM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 7 2019, 2:56 AM
Herald added subscribers: MaskRay, arichardson, emaste. · View Herald Transcript
grimar added a parent revision: D59082: [yaml2obj] - Allow producing ELFDATANONE ELFs.Mar 7 2019, 2:56 AM
grimar updated this revision to Diff 189678.Mar 7 2019, 3:00 AM
  • Added missing "# REQUIRES: x86"
grimar added a comment.Mar 11 2019, 8:44 AM

Could you look, Rui? This one is trivial, and I posted this because of D59082, which was accepted.

ruiu added inline comments.Mar 11 2019, 8:50 AM
test/ELF/invalid/data-encoding.test
8

Please add the ".o" extension to an object file.

13

It is not clear to me why you had to create an object file in addition to an archive file. Can't you just pass an archive file only?

grimar marked an inline comment as done.Mar 11 2019, 9:04 AM
grimar added inline comments.
test/ELF/invalid/data-encoding.test
13

I do not remember right now, sorry. I'll recheck tomorrow.

MaskRay added inline comments.Mar 11 2019, 11:36 PM
test/ELF/invalid/data-encoding.test
13

If the object file is not passed => ld.lld: error: target emulation unknown: -m or at least one .o file required. --whole-archive can be used.

grimar updated this revision to Diff 190224.Mar 12 2019, 2:23 AM
grimar marked an inline comment as done.
  • Addressed review comments.
test/ELF/invalid/data-encoding.test
13

Right. I used --whole-archive, thanks!

ruiu accepted this revision.Mar 13 2019, 3:42 PM

LGTM

This revision is now accepted and ready to land.Mar 13 2019, 3:42 PM
Closed by commit rLLD356334: [LLD][ELF] - Replace one of the tests with a YAML version. (authored by grimar). · Explain WhyMar 17 2019, 8:44 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2019, 8:44 AM

Revision Contents

PathSize
test/
ELF/
invalid/
Inputs/
18 lines
4 lines

Diff 189676

test/ELF/invalid/Inputs/data-encoding.a

  • This binary file was deleted.

test/ELF/invalid/data-encoding.test

  • This file was added.
# The object in the archive has invalid data encoding.
# Check we report this.
# RUN: echo ".long foo" > %t.s
# RUN: llvm-mc %t.s -o %t -filetype=obj -triple x86_64-pc-linux
# RUN: yaml2obj %s -o %t.o
# RUN: llvm-ar rcs %t.a %t.o
ruiuUnsubmitted
Not Done
ReplyInline Actions

Please add the ".o" extension to an object file.

ruiu: Please add the ".o" extension to an object file.
# RUN: not ld.lld %t %t.a -o %t2 2>&1 | FileCheck %s
# CHECK: {{.*}}.o: invalid data encoding
--- !ELF
ruiuUnsubmitted
Not Done
ReplyInline Actions

It is not clear to me why you had to create an object file in addition to an archive file. Can't you just pass an archive file only?

ruiu: It is not clear to me why you had to create an object file in addition to an archive file.
grimarAuthorUnsubmitted
Done
ReplyInline Actions

I do not remember right now, sorry. I'll recheck tomorrow.

grimar: I do not remember right now, sorry. I'll recheck tomorrow.
MaskRayUnsubmitted
Not Done
ReplyInline Actions

If the object file is not passed => ld.lld: error: target emulation unknown: -m or at least one .o file required. --whole-archive can be used.

MaskRay: If the object file is not passed => `ld.lld: error: target emulation unknown: -m or at least…
grimarAuthorUnsubmitted
Done
ReplyInline Actions

Right. I used --whole-archive, thanks!

grimar: Right. I used `--whole-archive`, thanks!
FileHeader:
Class: ELFCLASS64
Data: ELFDATANONE
Type: ET_REL
Machine: EM_X86_64

test/ELF/invalid/invalid-elf.test

# REQUIRES: x86 # REQUIRES: x86
# RUN: llvm-mc %s -o %t -filetype=obj -triple x86_64-pc-linux # RUN: llvm-mc %s -o %t -filetype=obj -triple x86_64-pc-linux
# RUN: not ld.lld %t %p/Inputs/data-encoding.a -o %t2 2>&1 | \
# RUN: FileCheck --check-prefix=INVALID-DATA-ENC %s
# INVALID-DATA-ENC: test.o: invalid data encoding
# RUN: not ld.lld %t %p/Inputs/file-class.a -o %t2 2>&1 | \ # RUN: not ld.lld %t %p/Inputs/file-class.a -o %t2 2>&1 | \
# RUN: FileCheck --check-prefix=INVALID-FILE-CLASS %s # RUN: FileCheck --check-prefix=INVALID-FILE-CLASS %s
# INVALID-FILE-CLASS: test.o: invalid file class # INVALID-FILE-CLASS: test.o: invalid file class
# RUN: not ld.lld %p/Inputs/binding.elf -o %t2 2>&1 | \ # RUN: not ld.lld %p/Inputs/binding.elf -o %t2 2>&1 | \
# RUN: FileCheck --check-prefix=INVALID-BINDING %s # RUN: FileCheck --check-prefix=INVALID-BINDING %s
# INVALID-BINDING: unexpected binding # INVALID-BINDING: unexpected binding
Show All 9 Lines