This is an archive of the discontinued LLVM Phabricator instance.

Remove `static` from declarations in support/musl/xlocale.h
AbandonedPublic

Authored by MaskRay on Mar 5 2019, 4:41 AM.

Details

Reviewers
EricWF
ca6c
Summary

libc++ fails to build with

LIBCXX_HAS_MUSL_LIBC=ON

complaining about static declarations. Removing it helps.

Diff Detail

Repository
rCXX libc++

Event Timeline

ca6c created this revision.Mar 5 2019, 4:41 AM
ca6c added a reviewer: EricWF.Apr 3 2019, 11:40 PM

I think I'd like to see the actual error messages.

ca6c added a comment.Apr 23 2019, 12:49 PM

I think I'd like to see the actual error messages.

Hello,

Sorry for the delay. Here they are:

In file included from /mnt/build/test/llvm/projects/libcxx/include/__locale:39,
                 from /mnt/build/test/llvm/projects/libcxx/include/ios:216,
                 from /mnt/build/test/llvm/projects/libcxx/include/ostream:138,
                 from /mnt/build/test/llvm/projects/libcxx/include/istream:163,
                 from /mnt/build/test/llvm/projects/libcxx/include/random:1646,
                 from /mnt/build/test/llvm/projects/libcxx/src/algorithm.cpp:11:
/mnt/build/test/llvm/projects/libcxx/include/support/musl/xlocale.h:28:25: error: ‘long long int strtoll_l(const char*, char**, int, locale_t)’ was declared ‘extern’ and later ‘static’ [-fpermissive]
 static inline long long strtoll_l(const char *nptr, char **endptr, int base,

and so on for each declaration.

MaskRay commandeered this revision.Dec 31 2020, 11:54 AM
MaskRay added a reviewer: ca6c.
MaskRay added a subscriber: MaskRay.

-DLIBCXX_HAS_MUSL_LIBC=ON works. Closing

MaskRay abandoned this revision.Dec 31 2020, 11:54 AM