Page MenuHomePhabricator

[Subtarget] Create a separate SubtargetSubtargetKV struct for ProcDesc to remove fields from the stack tables that aren't needed for CPUs
ClosedPublic

Authored by craig.topper on Mar 4 2019, 4:51 PM.

Details

Summary

The description for CPUs was just the CPU name wrapped with "Select the " and " processor". We can just do that directly in the help printer instead of repeating it for every CPU.

Also remove the Value field that isn't needed and was always 0.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 4 2019, 4:51 PM
andreadb accepted this revision.Mar 5 2019, 4:09 AM

Looks good to me.

I verified that we no longer generate the "Select the XXX processor" string in X86SubTypeKV, and that the unused (always zero) field of that struct is removed by your patch.

This revision is now accepted and ready to land.Mar 5 2019, 4:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2019, 10:54 AM