Page MenuHomePhabricator

[opt] Report if the provided architecture is invalid.
ClosedPublic

Authored by fhahn on Mar 4 2019, 3:41 PM.

Details

Summary

Partly addresses PR15026.

There are a few tests that passed in invalid architectures, which are fixed in: rL355349 and D58931

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Mar 4 2019, 3:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2019, 3:41 PM
fhahn edited the summary of this revision. (Show Details)
efriedma accepted this revision.Mar 4 2019, 3:54 PM

LGTM

llvm/tools/opt/opt.cpp
644 ↗(On Diff #189224)

I would probably say "unrecognized architecture" or something like that... but that's just nitpicking.

This revision is now accepted and ready to land.Mar 4 2019, 3:54 PM
fhahn updated this revision to Diff 189249.Mar 4 2019, 5:42 PM

Thanks Eli! I've updated the message to say unrecognized, which sounds better to me too.

This revision was automatically updated to reflect the committed changes.