This is an archive of the discontinued LLVM Phabricator instance.

[SCEV] Remove undef check for SCEVConstant (NFC)
ClosedPublic

Authored by fhahn on Mar 1 2019, 2:52 PM.

Reviewers

mkazantsev
sanjoy

Commits

Summary

The value stored in SCEVConstant is of type ConstantInt*, which can
never be UndefValue. So we should never hit that code.

Repository

rG LLVM Github Monorepo

Build Status

Buildable 28689
Build 28688: arc lint + arc unit

lgtm

This revision is now accepted and ready to land.Mar 1 2019, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Analysis/

2 lines

Show First 20 Lines • Show All 10,818 Lines • ▼ Show 20 Lines	return cast<SCEVAddRecExpr>(SE.getAddRecExpr(Ops, getLoop(),
SCEV::FlagAnyWrap));		SCEV::FlagAnyWrap));
}		}

// Return true when S contains at least an undef value.		// Return true when S contains at least an undef value.
static inline bool containsUndefs(const SCEV *S) {		static inline bool containsUndefs(const SCEV *S) {
return SCEVExprContains(S, [](const SCEV *S) {		return SCEVExprContains(S, [](const SCEV *S) {
if (const auto *SU = dyn_cast<SCEVUnknown>(S))		if (const auto *SU = dyn_cast<SCEVUnknown>(S))
return isa<UndefValue>(SU->getValue());		return isa<UndefValue>(SU->getValue());
else if (const auto *SC = dyn_cast<SCEVConstant>(S))
return isa<UndefValue>(SC->getValue());
return false;		return false;
});		});
}		}

namespace {		namespace {

// Collect all steps of SCEV expressions.		// Collect all steps of SCEV expressions.
struct SCEVCollectStrides {		struct SCEVCollectStrides {
▲ Show 20 Lines • Show All 1,635 Lines • Show Last 20 Lines