Page MenuHomePhabricator

[ARM] Consider undefined-on-NaN conditions in checkVSELConstraints
ClosedPublic

Authored by olista01 on Mar 1 2019, 1:27 AM.

Details

Summary

This function was not checking for the condition code variants which are undefined if either input is NaN, so we were missing selection of the VSEL instruction in some cases when using -fno-honor-nans or -ffast-math.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Mar 1 2019, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2019, 1:27 AM
SjoerdMeijer accepted this revision.Mar 1 2019, 3:54 AM

Looks like a good fix to me

This revision is now accepted and ready to land.Mar 1 2019, 3:54 AM
This revision was automatically updated to reflect the committed changes.