This is an archive of the discontinued LLVM Phabricator instance.

Differential D58755

[sanitizer] Build everything everywhere with -z text.
ClosedPublic

Authored by eugenis on Feb 27 2019, 6:05 PM.

Details

Reviewers
pcc
phosek
Commits
rG9ca1755f76c5: [sanitizer] Build everything whereever possible with -z text.
rCRT355164: [sanitizer] Build everything whereever possible with -z text.
rL355164: [sanitizer] Build everything whereever possible with -z text.

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis created this revision.Feb 27 2019, 6:05 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 27 2019, 6:05 PM
Herald added subscribers: Restricted Project, mgorny. · View Herald Transcript
eugenis mentioned this in D58533: [hwasan, asan] Intercept vfork..Feb 27 2019, 6:06 PM
Harbormaster completed remote builds in B28617: Diff 188657.Feb 27 2019, 6:07 PM
pcc accepted this revision.Feb 27 2019, 6:14 PM

LGTM

Though I probably won't say "everywhere" since it won't happen on Mac or Win.

This revision is now accepted and ready to land.Feb 27 2019, 6:14 PM
Closed by commit rL355164: [sanitizer] Build everything whereever possible with -z text. (authored by eugenis). · Explain WhyFeb 28 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptFeb 28 2019, 5:44 PM

Revision Contents

PathSize
compiler-rt/
trunk/
1 line
cmake/
2 lines

Diff 188826

compiler-rt/trunk/CMakeLists.txt

Show First 20 Lines • Show All 399 Lines • ▼ Show 20 Lines
append_list_if(COMPILER_RT_HAS_WD4391_FLAG /wd4391 SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_WD4391_FLAG /wd4391 SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_WD4722_FLAG /wd4722 SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_WD4722_FLAG /wd4722 SANITIZER_COMMON_CFLAGS)
append_list_if(COMPILER_RT_HAS_WD4800_FLAG /wd4800 SANITIZER_COMMON_CFLAGS) append_list_if(COMPILER_RT_HAS_WD4800_FLAG /wd4800 SANITIZER_COMMON_CFLAGS)
append_list_if(MINGW -fms-extensions SANITIZER_COMMON_CFLAGS) append_list_if(MINGW -fms-extensions SANITIZER_COMMON_CFLAGS)
# Set common link flags. # Set common link flags.
append_list_if(COMPILER_RT_HAS_NODEFAULTLIBS_FLAG -nodefaultlibs SANITIZER_COMMON_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_NODEFAULTLIBS_FLAG -nodefaultlibs SANITIZER_COMMON_LINK_FLAGS)
append_list_if(COMPILER_RT_HAS_Z_TEXT -Wl,-z,text SANITIZER_COMMON_LINK_FLAGS)
if (COMPILER_RT_USE_BUILTINS_LIBRARY) if (COMPILER_RT_USE_BUILTINS_LIBRARY)
list(APPEND SANITIZER_COMMON_LINK_LIBS ${COMPILER_RT_BUILTINS_LIBRARY}) list(APPEND SANITIZER_COMMON_LINK_LIBS ${COMPILER_RT_BUILTINS_LIBRARY})
string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}") string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}")
else() else()
if (ANDROID) if (ANDROID)
append_list_if(COMPILER_RT_HAS_GCC_LIB gcc SANITIZER_COMMON_LINK_LIBS) append_list_if(COMPILER_RT_HAS_GCC_LIB gcc SANITIZER_COMMON_LINK_LIBS)
else() else()
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

compiler-rt/trunk/cmake/config-ix.cmake

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Lines
if (ANDROID AND COMPILER_RT_HAS_LIBDL) if (ANDROID AND COMPILER_RT_HAS_LIBDL)
# Android's libstdc++ has a dependency on libdl. # Android's libstdc++ has a dependency on libdl.
list(APPEND CMAKE_REQUIRED_LIBRARIES dl) list(APPEND CMAKE_REQUIRED_LIBRARIES dl)
endif() endif()
check_library_exists(c++ __cxa_throw "" COMPILER_RT_HAS_LIBCXX) check_library_exists(c++ __cxa_throw "" COMPILER_RT_HAS_LIBCXX)
check_library_exists(stdc++ __cxa_throw "" COMPILER_RT_HAS_LIBSTDCXX) check_library_exists(stdc++ __cxa_throw "" COMPILER_RT_HAS_LIBSTDCXX)
# Linker flags. # Linker flags.
check_linker_flag("-Wl,-z,text" COMPILER_RT_HAS_Z_TEXT)
if(ANDROID) if(ANDROID)
check_linker_flag("-Wl,-z,global" COMPILER_RT_HAS_Z_GLOBAL) check_linker_flag("-Wl,-z,global" COMPILER_RT_HAS_Z_GLOBAL)
check_library_exists(log __android_log_write "" COMPILER_RT_HAS_LIBLOG) check_library_exists(log __android_log_write "" COMPILER_RT_HAS_LIBLOG)
endif() endif()
# Architectures. # Architectures.
# List of all architectures we can target. # List of all architectures we can target.
▲ Show 20 Lines • Show All 523 Lines • Show Last 20 Lines