Page MenuHomePhabricator

[AArch64][GlobalISel] Add isel support for G_UADDO on s32s and s64s
ClosedPublic

Authored by paquette on Feb 27 2019, 12:53 PM.

Details

Summary

This adds instruction selection support for G_UADDO on s32s and s64s.

Also

  • Add an instruction selection test
  • Update the arm64-xaluo.ll test to show that we generate the correct assembly

Diff Detail

Repository
rL LLVM

Event Timeline

paquette created this revision.Feb 27 2019, 12:53 PM
arsenm added a subscriber: arsenm.Feb 27 2019, 12:55 PM
arsenm added inline comments.
lib/Target/AArch64/AArch64InstructionSelector.cpp
1325–1326 ↗(On Diff #188605)

This is illegal, this can only be a register

paquette marked 2 inline comments as done.Feb 27 2019, 12:58 PM
paquette added inline comments.
lib/Target/AArch64/AArch64InstructionSelector.cpp
1325–1326 ↗(On Diff #188605)

Oh, whoops, I was just looking at ADDS. You're right, I'll change that.

paquette updated this revision to Diff 188607.Feb 27 2019, 12:59 PM
paquette marked an inline comment as done.

Remove illegal case

aemerson accepted this revision.Mar 14 2019, 1:02 PM

Can you switch to using MachineIRBuilder before committing.

test/CodeGen/AArch64/arm64-xaluo.ll
809 ↗(On Diff #188607)

Stray deletion

This revision is now accepted and ready to land.Mar 14 2019, 1:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2019, 3:54 PM