Page MenuHomePhabricator

[TableGen] Make OpcodeMappings sort comparator deterministic NFCI
ClosedPublic

Authored by andrewng on Feb 26 2019, 10:22 AM.

Details

Summary

The previous sort comparator was not deterministic, i.e. in some
situations it would be possible for lhs < rhs && rhs < lhs. This was
discovered by an STL assertion in a Windows debug build of llvm-tblgen.

Diff Detail

Repository
rL LLVM

Event Timeline

andrewng created this revision.Feb 26 2019, 10:22 AM
andreadb accepted this revision.Feb 26 2019, 10:38 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Feb 26 2019, 10:38 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 26 2019, 10:50 AM