This is an archive of the discontinued LLVM Phabricator instance.

Differential D58414

[WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT
ClosedPublic

Authored by aardappel on Feb 19 2019, 3:39 PM.

Details

Reviewers
aheejin
Commits
rG8a28ce1a123a: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT
rL354416: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT

Diff Detail

Event Timeline

aardappel created this revision.Feb 19 2019, 3:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2019, 3:39 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B28303: Diff 187463.Feb 19 2019, 3:40 PM
aheejin accepted this revision.Feb 19 2019, 4:46 PM

Thank you!

This revision is now accepted and ready to land.Feb 19 2019, 4:46 PM
Closed by commit rL354416: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT (authored by aardappel). · Explain WhyFeb 19 2019, 4:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
WebAssembly/
Disassembler/
1 line
test/
MC/
Disassembler/
WebAssembly/
3 lines

Diff 187463

lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp

Show First 20 Lines • Show All 193 Lines • ▼ Show 20 Lines for (uint8_t OPI = 0; OPI < WasmInst->NumOperands; OPI++) {
// ULEB operands: // ULEB operands:
case WebAssembly::OPERAND_BASIC_BLOCK: case WebAssembly::OPERAND_BASIC_BLOCK:
case WebAssembly::OPERAND_LOCAL: case WebAssembly::OPERAND_LOCAL:
case WebAssembly::OPERAND_GLOBAL: case WebAssembly::OPERAND_GLOBAL:
case WebAssembly::OPERAND_FUNCTION32: case WebAssembly::OPERAND_FUNCTION32:
case WebAssembly::OPERAND_OFFSET32: case WebAssembly::OPERAND_OFFSET32:
case WebAssembly::OPERAND_P2ALIGN: case WebAssembly::OPERAND_P2ALIGN:
case WebAssembly::OPERAND_TYPEINDEX: case WebAssembly::OPERAND_TYPEINDEX:
case WebAssembly::OPERAND_EVENT:
case MCOI::OPERAND_IMMEDIATE: { case MCOI::OPERAND_IMMEDIATE: {
if (!parseLEBImmediate(MI, Size, Bytes, false)) if (!parseLEBImmediate(MI, Size, Bytes, false))
return MCDisassembler::Fail; return MCDisassembler::Fail;
break; break;
} }
// SLEB operands: // SLEB operands:
case WebAssembly::OPERAND_I32IMM: case WebAssembly::OPERAND_I32IMM:
case WebAssembly::OPERAND_I64IMM: { case WebAssembly::OPERAND_I64IMM: {
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines

test/MC/Disassembler/WebAssembly/wasm.txt

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
# Check br_table, which has its own operand type. # Check br_table, which has its own operand type.
# CHECK: br_table {0, 1, 2} # CHECK: br_table {0, 1, 2}
0x0E 0x02 0x00 0x01 0x02 0x0E 0x02 0x00 0x01 0x02
# This can mean end_block/end_loop/end_if/end_function/end_try.. # This can mean end_block/end_loop/end_if/end_function/end_try..
# CHECK: end # CHECK: end
0x0B 0x0B
# CHECK: br_on_exn 0, 0
0x0A 0x00 0x00