This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Include CheckSymbolExists in HandleLLVMOptions
AbandonedPublic

Authored by phosek on Feb 19 2019, 2:15 PM.

Details

Summary

In LLVM build, HandLLVMOptions relies on CheckSymbolExists being
included by config-ix, but HandleLLVMOptions is also being imported
from other parts of the build such as the runtimes build, libunwind,
libcxxabi, libcxx, and none of those include LLVM's config-ix which
is breaking the build. We should include CheckSymbolExists directly
in HandleLLVMOptions to make it self-contained rather than relying
on config-ix.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Feb 19 2019, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2019, 2:15 PM
phosek abandoned this revision.Feb 19 2019, 2:16 PM

@dsanders already made this change in rL354389.