This is an archive of the discontinued LLVM Phabricator instance.

Set cmake policy CMP0075 to NEW
ClosedPublic

Authored by labath on Feb 15 2019, 5:23 AM.

Download Raw Diff

Details

Reviewers

sgraenitz
xiaobai

Commits

rLLDB354251: Set cmake policy CMP0075 to NEW
rG105f94914975: Set cmake policy CMP0075 to NEW
rL354251: Set cmake policy CMP0075 to NEW

Summary

The policy is about cmake_include_files ignoring
CMAKE_REQUIRED_LIBRARIES in the OLD behavior. Llvm already sets this
policy to NEW, but that is overridden by our cmake_minimum_required
command.

This makes our cmake policy setup consistent with the llvm build files
and avoids a warning when using newer versions of cmake.

Diff Detail

Repository: rL LLVM

Event Timeline

labath created this revision.Feb 15 2019, 5:23 AM

Herald added a subscriber: mgorny. · View Herald TranscriptFeb 15 2019, 5:24 AM

Harbormaster completed remote builds in B28188: Diff 187001.Feb 15 2019, 5:24 AM

LGTM

This revision is now accepted and ready to land.Feb 15 2019, 11:49 AM

Closed by commit rL354251: Set cmake policy CMP0075 to NEW (authored by labath). · Explain WhyFeb 18 2019, 2:09 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2019, 2:09 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

lldb/

trunk/

CMakeLists.txt

4 lines

Diff 187200

lldb/trunk/CMakeLists.txt

	cmake_minimum_required(VERSION 3.4.3)			cmake_minimum_required(VERSION 3.4.3)

				if(POLICY CMP0075)
				cmake_policy(SET CMP0075 NEW)
				endif()

	# Add path for custom modules			# Add path for custom modules
	set(CMAKE_MODULE_PATH			set(CMAKE_MODULE_PATH
	${CMAKE_MODULE_PATH}			${CMAKE_MODULE_PATH}
	"${CMAKE_CURRENT_SOURCE_DIR}/cmake"			"${CMAKE_CURRENT_SOURCE_DIR}/cmake"
	"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"			"${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
	)			)

	include(LLDBStandalone)			include(LLDBStandalone)
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines